Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setpoint as default sitemap element for item with tag "Setpoint" #3364

Merged
merged 2 commits into from
Feb 12, 2023
+12 −0
Merged

Use setpoint as default sitemap element for item with tag "Setpoint" #3364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
778d73c
Use setpoint as default sitemap element for item with tag "Setpoint"
lolodomo Feb 12, 2023
bb87214
Review comment: rather define a hasItemTag method
lolodomo Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ....openhab.core.ui/src/main/java/org/openhab/core/ui/internal/items/ItemUIRegistryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,9 @@ private void applyConfig(@Nullable Map<String, Object> config) {
}
if (!isReadOnly && hasStateOptions(itemName)) {
return SitemapFactory.eINSTANCE.createSelection();
}
if (!isReadOnly && NumberItem.class.isAssignableFrom(itemType) && hasItemTag(itemName, "Setpoint")) {
return SitemapFactory.eINSTANCE.createSetpoint();
} else {
return SitemapFactory.eINSTANCE.createText();
}
Expand Down Expand Up @@ -856,6 +859,15 @@ private int getCommandOptionsSize(String itemName) {
}
}

private boolean hasItemTag(String itemName, String tag) {
try {
Item item = getItem(itemName);
return item.hasTag(tag);
} catch (ItemNotFoundException e) {
return false;
}
}

@Override
public Item getItem(String name) throws ItemNotFoundException {
return itemRegistry.getItem(name);
Expand Down