Extend "iconcolor" attribute to all sitemap elements #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute was already available in syntax for the Image element but was probably not used by any UI. It is now available for any sitemap element and allows defining a color for the widget icon based on conditional statements on the item value. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
J-N-K
requested changes
Feb 25, 2023
...rest.sitemap/src/main/java/org/openhab/core/io/rest/sitemap/internal/PageChangeListener.java
Outdated
Show resolved
Hide resolved
J-N-K
changed the title
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
For information |
This was referenced Mar 5, 2023
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Mar 6, 2023
Refs openhab/openhab-core#3403. Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* iconcolor attribute added to all sitemap elements This attribute was already available in syntax for the Image element but was probably not used by any UI. It is now available for any sitemap element and allows defining a color for the widget icon based on conditional statements on the item value. Signed-off-by: Laurent Garnier <lg.hc@free.fr> GitOrigin-RevId: f2b8fa7
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/android-app-iconcolor-on-sitemap-is-buggy/149012/15 |
maniac103
added a commit
to maniac103/openhab.android
that referenced
this pull request
Sep 5, 2023
Support for that field was added in openhab/openhab-core#3403 Fixes openhab#3466 Signed-off-by: Danny Baumann <dannybaumann@web.de>
mueller-ma
pushed a commit
to openhab/openhab-android
that referenced
this pull request
Sep 5, 2023
Support for that field was added in openhab/openhab-core#3403 Fixes #3466 Signed-off-by: Danny Baumann <dannybaumann@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute was already available in syntax for the Image element but was probably not used by any UI.
It is now available for any sitemap element and allows defining a color for the widget icon based on conditional statements on the item value.
Signed-off-by: Laurent Garnier lg.hc@free.fr