Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] Support iconcolor for all elements in sitemap editor #1772

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[MainUI] Support iconcolor for all elements in sitemap editor #1772

merged 1 commit into from
Mar 6, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Mar 6, 2023 •
edited by florian-h05
Loading

@mherwege
add iconcolor to all elements
1e3a507 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner March 6, 2023 00:12
@mherwege mherwege mentioned this pull request Mar 6, 2023
Closed
3 tasks
@relativeci
Copy link

relativeci bot commented Mar 6, 2023

Job #835: Bundle Size — 16.25MiB (~+0.01%).

196fabf(current) vs f1e63fb main#834(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (2 changes)
                 Current
Job #835		      Baseline
Job #834
Initial JS 1.86MiB(~+0.01%) 1.86MiB
Initial CSS 608.62KiB 608.62KiB
Cache Invalidation 90.64% 90.65%
Chunks 218 218
Assets 688 688
Modules 1706 1706
Duplicate Modules 82 82
Duplicate Code 1.71% 1.71%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #835		      Baseline
Job #834
CSS 857.89KiB 857.89KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.2MiB (~+0.01%) 9.2MiB
Media 295.6KiB 295.6KiB
Other 4.71MiB (~+0.01%) 4.71MiB

View job #835 report View main branch activity

@florian-h05 florian-h05 changed the title [mainui] sitemap config add iconcolor to all elements [MainUI] Support iconcolor for all elements in sitemap editor Mar 6, 2023
florian-h05
florian-h05 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit c2f31f2 into openhab:main Mar 6, 2023
@mherwege mherwege deleted the sitemap_iconcolor_config branch March 7, 2023 08:51
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Mar 8, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mherwege @florian-h05