Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Input widget to main UI sitemap configuration and REST API #3431

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Add Input widget to main UI sitemap configuration and REST API #3431

merged 3 commits into from
Apr 13, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Mar 7, 2023 •
edited
Loading

Recreated #3419 as there was a mixup in my local branches.

This was missed in openhab/openhab-webui#1735

Extended to cover REST API and inputHint parameter to the Input element.

@mherwege mherwege requested a review from a team as a code owner March 7, 2023 09:30
lolodomo
lolodomo approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@J-N-K : can you please have a look?

@J-N-K J-N-K added rebuild Triggers the Jenkins PR build enhancement An enhancement or new feature of the Core and removed rebuild Triggers the Jenkins PR build labels Mar 19, 2023
@mherwege mherwege mentioned this pull request Mar 25, 2023
Merged
@mherwege mherwege changed the title Add Input widget to main UI sitemap configuration Add Input widget to main UI sitemap configuration and REST API Mar 26, 2023
mherwege added 3 commits April 3, 2023 10:47
@mherwege
add input widget to UI SitemapProviderImpl
fff1bec 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
inputHint in UIComponentSitemapProvider
8ecf2bb 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
add input element to REST
e134670 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@lolodomo
Copy link
Contributor

lolodomo commented Apr 8, 2023

This PR looks good to me.
Only comment: I am not sure to understand why Main UI is mentioned in the PR title. Is there anything here that has a link with MainUI ?
@J-N-K : is it possible to merge this PR so that other UIs can start implementing the input hint stuff.

@mherwege
Copy link
Contributor Author

mherwege commented Apr 8, 2023

This PR looks good to me.
Only comment: I am not sure to understand why Main UI is mentioned in the PR title. Is there anything here that has a link with MainUI ?
@J-N-K : is it possible to merge this PR so that other UIs can start implementing the input hint stuff.

The UIComponentSitemapProvider is specifically for configuring sitemaps in MainUI. That was the original content of of this PR. The REST part got added afterwards.

@lolodomo
Copy link
Contributor

lolodomo commented Apr 8, 2023

The UIComponentSitemapProvider is specifically for configuring sitemaps in MainUI. That was the original content of of this PR.

Good to know, thank you for the information, it was not clear for me what is this provider.

@mherwege mherwege mentioned this pull request Apr 12, 2023
Merged
@mherwege
Copy link
Contributor Author

@lolodomo @J-N-K @mueller-ma I have now created a PR#3337 to support input elements in the Android app. To be able to further test and review, this PR should be merged first as it relies on it. Any chance to have a look?

@lolodomo
Copy link
Contributor

Already approved by myself but I am not a maintainer of the core framework, I cannot help more.

J-N-K
J-N-K approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@J-N-K J-N-K merged commit 44a146f into openhab:main Apr 13, 2023
@J-N-K J-N-K added this to the 4.0 milestone Apr 13, 2023
@mherwege mherwege deleted the sitemap_input_ui branch April 14, 2023 11:44
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@mherwege @splatch
Add Input widget to main UI sitemap configuration and REST API (openh…
e44b96f 
…ab#3431)

* add input widget to UI SitemapProviderImpl
* inputHint in UIComponentSitemapProvider
* add input element to REST

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
GitOrigin-RevId: 44a146f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mherwege @lolodomo @J-N-K