Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring Input element for sitemap model #1735

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Feb 27, 2023

openhab/openhab-core#3398 added an Input element to sitemaps.
A PR for BasicUI to support input elements is in progress (#1729).

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner February 27, 2023 14:55
@relativeci
Copy link

relativeci bot commented Feb 27, 2023

Job #802: Bundle Size — 16.25MiB (~-0.01%).

ee7a523(current) vs c71b2e1 main#801(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (3 changes)
                 Current
Job #802
     Baseline
Job #801
Initial JS 1.86MiB(~+0.01%) 1.86MiB
Initial CSS 608.52KiB(-0.04%) 608.76KiB
Cache Invalidation 90.65% 0.1%
Chunks 218 218
Assets 688 688
Modules 2020 2020
Duplicate Modules 108 108
Duplicate Code 1.74% 1.74%
Packages 138 138
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #802
     Baseline
Job #801
CSS 857.79KiB (-0.03%) 858.03KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.19MiB (~+0.01%) 9.19MiB
Media 295.6KiB 295.6KiB
Other 4.71MiB (~+0.01%) 4.71MiB

View job #802 reportView main branch activity

@florian-h05 florian-h05 changed the title [mainui] support configuring Input element in sitemap Support configuring Input type for sitemap model Feb 28, 2023
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Should I merge now or do you prefer waiting for #1729 to get merged?

@florian-h05 florian-h05 changed the title Support configuring Input type for sitemap model Support configuring Input element for sitemap model Feb 28, 2023
@florian-h05 florian-h05 changed the title Support configuring Input element for sitemap model [MainUI] Support configuring Input element for sitemap model Feb 28, 2023
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 28, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Feb 28, 2023
@florian-h05 florian-h05 changed the title [MainUI] Support configuring Input element for sitemap model Support configuring Input element for sitemap model Feb 28, 2023
@mherwege
Copy link
Contributor Author

Configuring it is already supported in text files, although no UI can use it yet. So I don’t think we have to wait for merging this. I am hopeful BasicUI will support it soon.

@florian-h05 florian-h05 merged commit a028d1c into openhab:main Feb 28, 2023
@ghys
Copy link
Member

ghys commented Mar 1, 2023

I'm late to this party but it might "unbalance" this popup here:
image

Maybe we can remove "List", what do those even do?

@florian-h05
Copy link
Contributor

I'm late to this party but it might "unbalance" this popup here:

It indeed does, but I don't see a problem in this fact.

Maybe we can remove "List", what do those even do?

Seems like they display a list by splitting the Item state using a user-configured separator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants