[ephemeris] Add support for overriding holiday definitions #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End Danish General Prayer Day Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
clinique
suggested changes
Apr 23, 2023
...b.core.ephemeris/src/main/java/org/openhab/core/ephemeris/internal/EphemerisManagerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
clinique
approved these changes
Apr 24, 2023
clinique
approved these changes
Apr 24, 2023
J-N-K
reviewed
May 1, 2023
...b.core.ephemeris/src/main/java/org/openhab/core/ephemeris/internal/EphemerisManagerImpl.java
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
ephemeris-holiday-override
branch
from
091dfa6 to
d2b8285
Compare
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
) * Add support for overriding holiday definitions End Danish General Prayer Day Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> GitOrigin-RevId: c846487
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jan 12, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.0 of a more actively maintained fork (de.focus-shift). * This add many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jan 12, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.0 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jan 12, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.0 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jan 12, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.1 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jan 14, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.2 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer
pushed a commit
that referenced
this pull request
Jan 14, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.2 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by #3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes #3544 Signed-off-by: Wouter Born <github@maindrain.net>
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.2 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Jollyday we are using was abandoned years ago, so the holiday definitions we are using are getting outdated as well.
This pull request introduces the possibility to override holiday definitions in core, and as an example contains updated Danish definitions, ending Great Prayer Day this year, since our government has abolished it from next year.
The obvious disadvantage is that we would then take over the maintenance. But on the other hand, they are not maintained upstream anymore, so at least it would improve the user experience. Additionally, it would not change the API, so upgrading to focus-shift later will be seamless for users.
Related to #3544