-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Jollyday to 0.23.2 #4033
Conversation
@wborn - great, thanks! A small note - this work-around should then be removed (the file deleted): openhab-core/bundles/org.openhab.core.ephemeris/src/main/resources/jollyday/holidays/Holidays_dk.xml Lines 1 to 17 in 9cb4b9e
and this test should still work: Lines 274 to 279 in 9cb4b9e
because upstream is well maintained: The work-around for ending the Danish Great Prayer Day was introduced by #3573. |
The test still succeeds after removal! |
226fd15
to
524ba67
Compare
eba2337
to
5e56688
Compare
Updates the URLs to the GitHub repo of the actively maintained Jollyday fork. Related to: openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Updates the URLs to the GitHub repo of the actively maintained Jollyday fork. Related to: openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Related to openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Updates the URLs to the GitHub repo of the actively maintained Jollyday fork. Related to: openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.2 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net>
5e56688
to
9157238
Compare
Related to openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Related to: openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related to: openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Related to openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Updates the URLs to the GitHub repo of the actively maintained Jollyday fork. Related to: openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.2 of a more actively maintained fork (de.focus-shift). * This adds many missing holidays. * Also removes the workaround for the Danish Great Prayer Day introduced by openhab#3573. For release notes, see: https://github.com/focus-shift/jollyday/releases Fixes openhab#3544 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Related to openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Related to openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Related to openhab/openhab-core#4033 Signed-off-by: Wouter Born <github@maindrain.net>
Upgrades Jollyday 0.5.10 (de.jollyday) to 0.23.2 of a more actively maintained fork (de.focus-shift).
For release notes, see:
https://github.com/focus-shift/jollyday/releases
Fixes #3544