-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Main UI docs for integration into sidebar help #2199
Add Main UI docs for integration into sidebar help #2199
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have now migrated all content that was hard-coded into the UI to the docs repo and created the structure for the new Main UI docs. You can run my linked UI PR locally to see how the UI integrates the docs. Feel free to extend the documentation, migrate docs from elsewhere in this repo and put some content into the empty files. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
ced2e65
to
921112f
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
80e88c3
to
9ae7489
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2cef667
to
ae20c8b
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
73f1cd0
to
120fd37
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
53de863
to
2f60e90
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2f60e90
to
e7676a6
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
4f45e36
to
76eaabe
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
76eaabe
to
7aecd66
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
30f11f2
to
ab92bbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florian-h05 This is an amazing contribution to the docs and you earn the docs gold medal for the month 🥇 🤩
Given the amount of text you contributed I only found only a few minor issues.
mainui/CONTRIBUTING.md
Outdated
Inside these comments, the UI allows the following features: | ||
|
||
- Embed [Framework7 icons](https://framework7.io/icons/) into the UI-rendered docs using these comments: | ||
- `<!--F7 $iconame -->`, where `$iconname` is a Framework7 icon's name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where $iconame
(one n too much)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is one n missing in $iconame
;-)
mainui/about.md
Outdated
- Logs folder on the server | ||
- Operating System openHAB is running on | ||
- Java Runtime openHAB is running on | ||
- number of processors and memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Number
mainui/about.md
Outdated
Main UI implements a web audio sink which allows the openHAB server to play audio through the web browser. | ||
|
||
To enable web audio sink support for a client, turn on the **Enable Web Audio sink support** option on the **Help & About** page. | ||
As it is setting specific to your browser environment, web audio support has to be enabled for every client where it should be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting-specific
mainui/about.md
Outdated
As it is setting specific to your browser environment, web audio support has to be enabled for every client where it should be used. | ||
|
||
Please note that due to limitations in Safari (and possibly Chrome as well), a user interaction is required after the first audio stream has been sent to actually play it. | ||
This means, that after opening Main UI, the first audio that should be played on the web audio sink is only player after the user interacts with Main UI in any way (i.e. touching the screen is enough). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only played
mainui/about.md
Outdated
|
||
Please note that due to limitations in Safari (and possibly Chrome as well), a user interaction is required after the first audio stream has been sent to actually play it. | ||
This means, that after opening Main UI, the first audio that should be played on the web audio sink is only player after the user interacts with Main UI in any way (i.e. touching the screen is enough). | ||
For subsequent audio playback, that is not required anymore and the audio is played immediately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For subsequent audio playback the above is not required anymore and the audio is played immediately.
mainui/settings/schedule.md
Outdated
|
||
![saturday-morning-rule](../images/saturday-rule-schedule.png) | ||
|
||
A rule that is schedule repeatedly like everyday at 8:00 in the morning will therefore be shown on every day of the calendar view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A rule that is scheduled repeatedly
mainui/settings/scripts.md
Outdated
<!-- START MAINUI SIDEBAR DOC - DO NOT REMOVE --> | ||
**Rules** are the heart of home automation. | ||
**Scripts** are special types of rules with only one action and no triggers, so they have to be called from "real" rules or run manually. | ||
They can be used to reuse code and logic across multiple other rules, one off experimentation to figure something out, create a catalog of examples, or to drive tests for other rules and behaviors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for experimentation to figure
mainui/settings/things.md
Outdated
- **Add new Things**<br> | ||
Use the [Thing Inbox](#inbox) to scan for available things or manually add ones that cannot be found automatically using the <!--F7:blue plus_circle_fill --> plus button. | ||
- **Configure Things**<br> | ||
Click on any Thing in the list to see its configuration page and it's channels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its channels.
mainui/settings/things.md
Outdated
It therefore makes a lot of sense to use these features for a smart home solution. | ||
|
||
openHAB bindings can therefore implement Discovery Services for Things, which provide Discovery Results. | ||
All Discovery Results are put into the Thing inbox, from where they can be easily added to openHAB with just a few clicks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thing inbox from where they can be
mainui/settings/transformations.md
Outdated
# Settings - Transformations | ||
|
||
<!-- START MAINUI SIDEBAR DOC - DO NOT REMOVE --> | ||
**Transformations** convert a value or Item state into different value or state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
into a different value
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@stefan-hoehn Thank you for your fast review of this big PR!! I have addressed your review.
Thank you very much, I guess I will share it with you since you wrote large parts of the docs that I moved around, and with @JustinGeorgi, who originally wrote what has been added to the UI and what I migrated to the docs repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now.
) Follow-up for #2088. Depends on openhab/openhab-docs#2199. Also add the help sidebar button to the settings and list pages where it is missing. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@ghys @Confectrician Why can’t I find that documentation changes on https://next.openhab.org/docs? |
@kaikreuzer Do you mind having a look. It is actually weird that we don't see the changes. I also don't see a way to trigger a new build. Do you know what happened here? An example would be https://next.openhab.org/docs/mainui/about.html which is missing. |
The website fails to build on Netlify since Jan 26th:
corresponding to this line in prepare-docs.rb: |
openhab/openhab-docs#2199 broke the website build due to the directory structure changes. This adjusts the build script and therefore fixes the website build. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
openhab/website#445 will fix the website build. |
* Adjust to openhab/openhab-docs#2199 openhab/openhab-docs#2199 broke the website build due to the directory structure changes. This adjusts the build script and therefore fixes the website build. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Required for openhab/openhab-webui#2253.
/cc @stefan-hoehn @Confectrician
Please have a look at the CONTRIBUTING.md inside the mainui folder.