-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help sidebar: Move docs to docs repo & Integrate them into the UI #2253
Help sidebar: Move docs to docs repo & Integrate them into the UI #2253
Conversation
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
TODO: Remove this before contributing to the UI codebase. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #1371: Bundle Size — 15.83MiB (-0.09%).Warning Bundle contains 16 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1371 report View florian-h05:help-sidebar-docs-in... branch activity View project dashboard |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
I think with the latest change you pushed, which we discussed offline, covering the non-availability of the internet, it is looking pretty good. I also looked through the code and I don't see any obvious issue. So, I think we are good to go. This PR, based on the related restructuring of the docs sidebar, is a great step forward for context sensitive in the UI and a good integration into the online docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I don't see any obvious issue.
Follow-up for #2088.
Depends on openhab/openhab-docs#2199.
Also add the help sidebar button to the settings and list pages where it is missing.