Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Wrong material icon size in condensed mode #2015

Closed
lolodomo opened this issue Aug 9, 2023 · 0 comments · Fixed by #2016
Closed

[BasicUI] Wrong material icon size in condensed mode #2015

lolodomo opened this issue Aug 9, 2023 · 0 comments · Fixed by #2016
Labels
basic ui Basic UI bug Something isn't working

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Aug 9, 2023

It is not very visible but in condensed mode the material icons should have a size 28x28, like OH icons but they have a size 32x32 like in normal mode.

@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Aug 9, 2023
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 10, 2023
Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 10, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 10, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 11, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Re-align material-icons.css to official file.

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 12, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

Fix
kaikreuzer pushed a commit that referenced this issue Aug 16, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Fixes #2011
Fixes #2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant