Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Some material icons missing #2011

Closed
lolodomo opened this issue Aug 9, 2023 · 2 comments · Fixed by #2016
Closed

[BasicUI] Some material icons missing #2011

lolodomo opened this issue Aug 9, 2023 · 2 comments · Fixed by #2016
Labels
basic ui Basic UI bug Something isn't working

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Aug 9, 2023

When implementing PR #2010, I discovered that some material icons were missing while they are supposed to exist, like for example this one: https://fonts.google.com/icons?selected=Material+Icons+Outlined:legend_toggle:&icon.set=Material+Icons&icon.query=legend+toggle

The reason could be that we rely on version 3.0.1:
https://github.com/openhab/openhab-webui/blob/main/bundles/org.openhab.ui.basic/package.json#L13

The last version is 4.0.0.
https://github.com/google/material-design-icons/releases/tag/4.0.0

@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Aug 9, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 9, 2023

if I changed the line in package.json to

"material-design-icons": "^4.0.0",

Then the build is failing, this version is apparently not found:

[INFO] --- frontend-maven-plugin:1.9.0:npm (npm install) @ org.openhab.ui.basic ---
[INFO] Running 'npm install' in D:\dev\openhab3\git\openhab-webui\bundles\org.openhab.ui.basic
[INFO] npm ERR! code ETARGET
[INFO] npm ERR! notarget No matching version found for material-design-icons@^4.0.0.
[INFO] npm ERR! notarget In most cases you or one of your dependencies are requesting
[INFO] npm ERR! notarget a package version that doesn't exist.

And

$ npm view  material-design-icons versions

[ '1.0.0',
  '1.0.1',
  '2.0.0',
  '2.1.0',
  '2.1.1',
  '2.1.3',
  '2.2.0',
  '2.2.1',
  '2.2.2',
  '2.2.3',
  '3.0.0',
  '3.0.1' ]

So more recent version is not published on npm repository :-(

https://www.npmjs.com/package/material-design-icons?activeTab=readme
google/material-design-icons#1129

@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 9, 2023

one option to try would be to switch from the official repo to https://github.com/marella/material-icons

lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 10, 2023
Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 10, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 10, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 11, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Re-align material-icons.css to official file.

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 12, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Fixes openhab#2011
Fixes openhab#2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

Fix
kaikreuzer pushed a commit that referenced this issue Aug 16, 2023
Move from the outdated official NPM module (material-design-icons) to an
alternative NPM module (material-icons) providing most recent material
icons.

As a consequence, TTF format is no more provided, only WOFF and WOFF2
formats. All current browsers support WOFF format, so only very old
browsers could be impacted by the miss of the TTF format.

Also fix icon size in condensed mode (28x28).

Fixes #2011
Fixes #2015

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant