-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BasicUI] Add a new header line for image, chart and video elements. #2010
Conversation
Another example to show when the elements are in the same frame:
|
My intention was to use icon in all buttons but some material icons I would like to use are missing. I will update a second step when all material icons are accessible. |
7a53d62
to
e5db294
Compare
Let's wait for the merge of #2016 so that I can include the icons I would like for the chart header line. |
e5db294
to
52f96f1
Compare
It feels a bit strange to me that one has to add a label to a chart to get the new buttons. Maybe show the header for charts always? |
Yes, you're right. Same for image. I will change that. |
753ca77
to
6c5bfc5
Compare
I have updated all the screenshots. |
6c5bfc5
to
52f4a6d
Compare
I discovered that the update of label/icon color is broken for the colorpicker with this PR. Put again this PR in WIP. |
Header line for video element contains icon and label. Header line for image element contains icon, label and a button to switch between no upscale and upscale of the image. Header line for chart element contains icon, label and 4 buttons: - one button to show or hide the legend - one button to change the time range - one button to switch between no upscale and upscale of the chart - one button to refresh the chart Fix handling of iconcolor and labelcolor parameters for mapview and webview elements. For image and chart elements, the header line is always present so that user has an access to its buttons. For video, mapview and webview elements, if the label is empty, the header line is hidden. For chart and image elements, there is now no upscale applied by default (tablet/phone devices) but a button allows upscaling. Closes openhab#1939 Fixes openhab#1367 Also related to openhab#1930 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
52f4a6d
to
dcd246d
Compare
It was just a mismatch between undefined and null in JavaScript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great enhancement, thank you!
Thank you for the review Kai. |
…penhab#2010) Header line for video element contains icon and label. Header line for image element contains icon, label and a button to switch between no upscale and upscale of the image. Header line for chart element contains icon, label and 4 buttons: - one button to show or hide the legend - one button to change the time range - one button to switch between no upscale and upscale of the chart - one button to refresh the chart Fix handling of iconcolor and labelcolor parameters for mapview and webview elements. For image and chart elements, the header line is always present so that user has an access to its buttons. For video, mapview and webview elements, if the label is empty, the header line is hidden. For chart and image elements, there is now no upscale applied by default (tablet/phone devices) but a button allows upscaling. Closes openhab#1939 Fixes openhab#1367 Also related to openhab#1930 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
…penhab#2010) Header line for video element contains icon and label. Header line for image element contains icon, label and a button to switch between no upscale and upscale of the image. Header line for chart element contains icon, label and 4 buttons: - one button to show or hide the legend - one button to change the time range - one button to switch between no upscale and upscale of the chart - one button to refresh the chart Fix handling of iconcolor and labelcolor parameters for mapview and webview elements. For image and chart elements, the header line is always present so that user has an access to its buttons. For video, mapview and webview elements, if the label is empty, the header line is hidden. For chart and image elements, there is now no upscale applied by default (tablet/phone devices) but a button allows upscaling. Closes openhab#1939 Fixes openhab#1367 Also related to openhab#1930 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
…penhab#2010) Header line for video element contains icon and label. Header line for image element contains icon, label and a button to switch between no upscale and upscale of the image. Header line for chart element contains icon, label and 4 buttons: - one button to show or hide the legend - one button to change the time range - one button to switch between no upscale and upscale of the chart - one button to refresh the chart Fix handling of iconcolor and labelcolor parameters for mapview and webview elements. For image and chart elements, the header line is always present so that user has an access to its buttons. For video, mapview and webview elements, if the label is empty, the header line is hidden. For chart and image elements, there is now no upscale applied by default (tablet/phone devices) but a button allows upscaling. Closes openhab#1939 Fixes openhab#1367 Also related to openhab#1930 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
…penhab#2010) Header line for video element contains icon and label. Header line for image element contains icon, label and a button to switch between no upscale and upscale of the image. Header line for chart element contains icon, label and 4 buttons: - one button to show or hide the legend - one button to change the time range - one button to switch between no upscale and upscale of the chart - one button to refresh the chart Fix handling of iconcolor and labelcolor parameters for mapview and webview elements. For image and chart elements, the header line is always present so that user has an access to its buttons. For video, mapview and webview elements, if the label is empty, the header line is hidden. For chart and image elements, there is now no upscale applied by default (tablet/phone devices) but a button allows upscaling. Closes openhab#1939 Fixes openhab#1367 Also related to openhab#1930 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Header line for video element contains icon and label.
Header line for image element contains icon, label and a button to switch between no upscale and upscale of the image. Header line for chart element contains icon, label and 4 buttons:
Fix handling of iconcolor and labelcolor parameters for mapview and webview elements.
For image and chart elements, the header line is always present so that user has an access to its buttons.
For video, mapview and webview elements, if the label is empty, the header line is hidden.
For chart and image elements, there is now no upscale applied by default (tablet/phone devices) but a button allows upscaling.
Closes #1939
Fixes #1367
Also related to #1930
Signed-off-by: Laurent Garnier lg.hc@free.fr