Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] Google Assistant class is not remembered in edit dialog #722

Closed
eikowagenknecht opened this issue Dec 28, 2020 · 1 comment · Fixed by #723
Closed

[MainUI] Google Assistant class is not remembered in edit dialog #722

eikowagenknecht opened this issue Dec 28, 2020 · 1 comment · Fixed by #723
Labels
bug Something isn't working main ui Main UI

Comments

@eikowagenknecht
Copy link
Contributor

The problem

The Google Assistant Class is not remembered in the Metadata edit screen. So when you edit it, it doesn't show the current value but an empty field:

image

Expected behavior

It should show the current value.

Steps to reproduce

  1. Add GA metadata to an item.
  2. Save
  3. Reopen the item > it's not there

Additional information

Problem is in item-metadata-ga.vue file, classes computed property is missing. Will fix this myself with a PR soon.
@eikowagenknecht eikowagenknecht added bug Something isn't working main ui Main UI labels Dec 28, 2020
@eikowagenknecht
Copy link
Contributor Author

Duplicate of #711

This was referenced Dec 28, 2020
Closed
Merged
ghys pushed a commit that referenced this issue Dec 29, 2020
@eikowagenknecht
Fix #722 - Show current GA metadata when editing (#723)
7d6579a 
Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
crnjan added a commit to crnjan/openhab-webui that referenced this issue Jan 6, 2021
@crnjan
Merge branch 'master' into fetaure/support_webos5_buildin_browser
91597d0 
* master:
  Take all door subclasses in door location glance badge (openhab#727)
  [habpanel] Remove ItemStateEvent detection (openhab#737)
  Update license headers to 2021 (openhab#739)
  Fix openhab#714 - Sort popup dialogs by name and jump to selected item on open (openhab#724)
  Fix openhab#538 - Do not concatenate search for items (openhab#726)
  Fix openhab#722 - Show current GA metadata when editing (openhab#723)
  Fix openhab#720 - Fix various problems with google assistant metadata UI (openhab#721)
  Fix openhab#684 - Allow diacritics in search bars (openhab#718)
  CSP: allow blob: URLs (openhab#698)
  Apply Spotless (openhab#680)
  [unleash-maven-plugin] Preparation for next development cycle.
ghys pushed a commit to ghys/openhab-webui that referenced this issue Jan 11, 2021
@eikowagenknecht @ghys
Fix openhab#722 - Show current GA metadata when editing (openhab#723)
6e3e6b2 
Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show current GA metadata when editing
1 participant
@eikowagenknecht