Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed ItemStateEvent if case #737

Merged
merged 1 commit into from
Jan 3, 2021
Merged

removed ItemStateEvent if case #737

merged 1 commit into from
Jan 3, 2021

Conversation

HolgerHees
Copy link
Contributor

this will never happend, because these events are filtered out before

@ghys
Copy link
Member

ghys commented Dec 31, 2020

Cool, since the small patch exceptions can't apply for code, could you add a sign-off line (as a comment below) as described in https://github.com/openhab/openhab-core/blob/master/CONTRIBUTING.md#sign-your-work? Thanks!

@HolgerHees
Copy link
Contributor Author

commit is signed now

this will never happend, because these events are filtered out before.

Signed-off-by: hhees <holger.hees@gmail.com>
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys merged commit e845079 into openhab:master Jan 3, 2021
crnjan added a commit to crnjan/openhab-webui that referenced this pull request Jan 6, 2021
* master:
  Take all door subclasses in door location glance badge (openhab#727)
  [habpanel] Remove ItemStateEvent detection (openhab#737)
  Update license headers to 2021 (openhab#739)
  Fix openhab#714 - Sort popup dialogs by name and jump to selected item on open (openhab#724)
  Fix openhab#538 - Do not concatenate search for items (openhab#726)
  Fix openhab#722 - Show current GA metadata when editing (openhab#723)
  Fix openhab#720 - Fix various problems with google assistant metadata UI (openhab#721)
  Fix openhab#684 - Allow diacritics in search bars (openhab#718)
  CSP: allow blob: URLs (openhab#698)
  Apply Spotless (openhab#680)
  [unleash-maven-plugin] Preparation for next development cycle.
@ghys ghys added the bug Something isn't working label Jan 11, 2021
@ghys ghys added this to the 3.1 milestone Jan 11, 2021
ghys pushed a commit to ghys/openhab-webui that referenced this pull request Jan 11, 2021
Signed-off-by: Holger Hees <holger.hees@gmail.com>
@ghys ghys added patch A PR that has been cherry-picked to a patch release branch habpanel ui labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working habpanel ui patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants