-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed ItemStateEvent if case #737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cool, since the small patch exceptions can't apply for code, could you add a sign-off line (as a comment below) as described in https://github.com/openhab/openhab-core/blob/master/CONTRIBUTING.md#sign-your-work? Thanks! |
commit is signed now |
this will never happend, because these events are filtered out before. Signed-off-by: hhees <holger.hees@gmail.com>
ghys
approved these changes
Jan 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
crnjan
added a commit
to crnjan/openhab-webui
that referenced
this pull request
Jan 6, 2021
* master: Take all door subclasses in door location glance badge (openhab#727) [habpanel] Remove ItemStateEvent detection (openhab#737) Update license headers to 2021 (openhab#739) Fix openhab#714 - Sort popup dialogs by name and jump to selected item on open (openhab#724) Fix openhab#538 - Do not concatenate search for items (openhab#726) Fix openhab#722 - Show current GA metadata when editing (openhab#723) Fix openhab#720 - Fix various problems with google assistant metadata UI (openhab#721) Fix openhab#684 - Allow diacritics in search bars (openhab#718) CSP: allow blob: URLs (openhab#698) Apply Spotless (openhab#680) [unleash-maven-plugin] Preparation for next development cycle.
ghys
pushed a commit
to ghys/openhab-webui
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Holger Hees <holger.hees@gmail.com>
ghys
added
patch
A PR that has been cherry-picked to a patch release branch
habpanel ui
labels
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
habpanel ui
patch
A PR that has been cherry-picked to a patch release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will never happend, because these events are filtered out before