Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link for oh-map-page docs #1704

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Fix link for oh-map-page docs #1704

merged 2 commits into from
Feb 16, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05
Fix link for oh-map-page docs
b8c4964 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from ghys February 12, 2023 18:46
@florian-h05 florian-h05 requested a review from a team as a code owner February 12, 2023 18:46
@florian-h05 florian-h05 mentioned this pull request Feb 12, 2023
Merged
@relativeci
Copy link

relativeci bot commented Feb 12, 2023 •
edited
Loading

Job #778: Bundle Size — 16.19MiB (-0.21%).

3495863(current) vs 69c9be2 main#777(baseline)

Metrics (3 changes)
                 Current
Job #778		      Baseline
Job #777
Initial JS 1.86MiB(-0.03%) 1.86MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.63% 90.61%
Chunks 218 218
Assets 688 688
Modules 2012(-0.35%) 2019
Duplicate Modules 108 108
Duplicate Code 1.74% 1.74%
Packages 137 137
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #778		      Baseline
Job #777
CSS 856.56KiB (-0.12%) 857.62KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.15MiB (-0.29%) 9.18MiB
Media 295.6KiB 295.6KiB
Other 4.7MiB (-0.13%) 4.7MiB

View job #778 report View main branch activity

@ghys
Copy link
Member

ghys commented Feb 16, 2023

Could you generate the .md files again using the script and include them in the PR (see https://github.com/openhab/openhab-webui/blob/main/bundles/org.openhab.ui/CONTRIBUTING.md#documentation--resources)?

@florian-h05
Copy link
Contributor Author

Yes — I thought I did this but obviously something went wrong when I commited.

@florian-h05
Regenerate component docs
c59884d 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor Author

@ghys Done.

@ghys ghys merged commit 5b680e3 into openhab:main Feb 16, 2023
@ghys ghys added bug Something isn't working main ui Main UI labels Feb 16, 2023
@ghys ghys added this to the 4.0 milestone Feb 16, 2023
@florian-h05 florian-h05 deleted the oh-map-page-fix-doc-link branch February 16, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @ghys