Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts v-if/v-show change from #2029 #2054

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

digitaldan
Copy link
Contributor

@digitaldan digitaldan commented Sep 4, 2023

Regression from #2029.

@florian-h05 i noticed when upgrading my system this AM that a few of my UI pages stopped loading properly. Specifically there seemed to be a condition where when the page would draw its widgets before other parts of the page were loaded ( or something similar, some race conditional). This would result in widgets loading with the wrong state, colors, icons, etc that are dependent on item state. I tracked it down to this one very small change, reverting back to a v-show from v-if for the main view ready state fixes this.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan digitaldan requested a review from a team as a code owner September 4, 2023 16:57
@relativeci
Copy link

relativeci bot commented Sep 4, 2023

Job #1140: Bundle Size — 15.76MiB (~+0.01%).

9b11e69(current) vs 62659de main#1139(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (2 changes)
                 Current
Job #1140
     Baseline
Job #1139
Initial JS 1.67MiB(~+0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.95%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1140
     Baseline
Job #1139
CSS 859.49KiB 859.49KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (~+0.01%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (~+0.01%) 4.73MiB

View job #1140 reportView main branch activity

@florian-h05
Copy link
Contributor

Ah sh*t.
So I have to find another way to fix #2006.

Since you tracked it down to this little change, let’s merge this PR then.

@florian-h05
Copy link
Contributor

@ghys FYI. Seems like there was a reason to use v-show …
Weird that I did not notice those problems, but TBH I haven’t tested this on my production, just on my limited dev setup.

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Sep 4, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Sep 4, 2023
@florian-h05 florian-h05 merged commit 303ab55 into openhab:main Sep 4, 2023
@florian-h05 florian-h05 changed the title Reverts v-if/v-show change from #2029. Reverts v-if/v-show change from #2029 Sep 4, 2023
ghys pushed a commit that referenced this pull request Sep 16, 2023
Fixes #2006.

With the attempt in #2029 failing due to #2054, this finally fixes an
issue where the semantic model pages (Equipment, Properties) were
missing translations.
This was due to a race condition, where the semantic model pages were
built before the tags were loaded.

This PR fixes this by watching for semantic model updates (i.e.
subscripting to the underlying Vuex mutation) and loading/building the
model pages after such an update.

Futher improvements:
- Initial loading of semantic tags is put in parallel with other API
requests performed on app init.
- Vuex semantics: A mutation is used for setting the semantic tags from
the action.
- Debug logging is added to both the semantic tag and the semantic model
page loading.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Sep 18, 2023
florian-h05 pushed a commit that referenced this pull request Sep 18, 2023
Regression from #2029.

A few of my UI pages stopped loading properly. Specifically there seemed to be a condition where when the page would draw its widgets before other parts
of the page were loaded (or something similar, some race conditional).
This would result in widgets loading with the wrong state, colors, icons, etc that are dependent on item state.

I tracked it down to this
one very small change, reverting back to a `v-show` from `v-if` for the
main view ready state fixes this.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
(cherry picked from commit 303ab55)
florian-h05 added a commit that referenced this pull request Sep 18, 2023
Fixes #2006.

With the attempt in #2029 failing due to #2054, this finally fixes an
issue where the semantic model pages (Equipment, Properties) were
missing translations.
This was due to a race condition, where the semantic model pages were
built before the tags were loaded.

This PR fixes this by watching for semantic model updates (i.e.
subscripting to the underlying Vuex mutation) and loading/building the
model pages after such an update.

Futher improvements:
- Initial loading of semantic tags is put in parallel with other API
requests performed on app init.
- Vuex semantics: A mutation is used for setting the semantic tags from
the action.
- Debug logging is added to both the semantic tag and the semantic model
page loading.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit f2c008b)
stefan-hoehn pushed a commit to stefan-hoehn/openhab-webui that referenced this pull request Sep 23, 2023
Regression from openhab#2029.

A few of my UI pages stopped loading properly. Specifically there seemed to be a condition where when the page would draw its widgets before other parts
of the page were loaded (or something similar, some race conditional).
This would result in widgets loading with the wrong state, colors, icons, etc that are dependent on item state.

I tracked it down to this
one very small change, reverting back to a `v-show` from `v-if` for the
main view ready state fixes this.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
stefan-hoehn pushed a commit to stefan-hoehn/openhab-webui that referenced this pull request Sep 23, 2023
…2066)

Fixes openhab#2006.

With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an
issue where the semantic model pages (Equipment, Properties) were
missing translations.
This was due to a race condition, where the semantic model pages were
built before the tags were loaded.

This PR fixes this by watching for semantic model updates (i.e.
subscripting to the underlying Vuex mutation) and loading/building the
model pages after such an update.

Futher improvements:
- Initial loading of semantic tags is put in parallel with other API
requests performed on app init.
- Vuex semantics: A mutation is used for setting the semantic tags from
the action.
- Debug logging is added to both the semantic tag and the semantic model
page loading.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
JustinGeorgi pushed a commit to JustinGeorgi/openhab-webui that referenced this pull request Sep 24, 2023
…2066)

Fixes openhab#2006.

With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an
issue where the semantic model pages (Equipment, Properties) were
missing translations.
This was due to a race condition, where the semantic model pages were
built before the tags were loaded.

This PR fixes this by watching for semantic model updates (i.e.
subscripting to the underlying Vuex mutation) and loading/building the
model pages after such an update.

Futher improvements:
- Initial loading of semantic tags is put in parallel with other API
requests performed on app init.
- Vuex semantics: A mutation is used for setting the semantic tags from
the action.
- Debug logging is added to both the semantic tag and the semantic model
page loading.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: jgeorgi <justin.georgi@gmail.com>
JustinGeorgi pushed a commit to JustinGeorgi/openhab-webui that referenced this pull request Sep 24, 2023
…2066)

Fixes openhab#2006.

With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an
issue where the semantic model pages (Equipment, Properties) were
missing translations.
This was due to a race condition, where the semantic model pages were
built before the tags were loaded.

This PR fixes this by watching for semantic model updates (i.e.
subscripting to the underlying Vuex mutation) and loading/building the
model pages after such an update.

Futher improvements:
- Initial loading of semantic tags is put in parallel with other API
requests performed on app init.
- Vuex semantics: A mutation is used for setting the semantic tags from
the action.
- Debug logging is added to both the semantic tag and the semantic model
page loading.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: jgeorgi <justin.georgi@gmail.com>
digitaldan pushed a commit to digitaldan/openhab-webui that referenced this pull request Sep 24, 2023
…2066)

Fixes openhab#2006.

With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an
issue where the semantic model pages (Equipment, Properties) were
missing translations.
This was due to a race condition, where the semantic model pages were
built before the tags were loaded.

This PR fixes this by watching for semantic model updates (i.e.
subscripting to the underlying Vuex mutation) and loading/building the
model pages after such an update.

Futher improvements:
- Initial loading of semantic tags is put in parallel with other API
requests performed on app init.
- Vuex semantics: A mutation is used for setting the semantic tags from
the action.
- Debug logging is added to both the semantic tag and the semantic model
page loading.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants