-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverts v-if/v-show change from #2029 #2054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Job #1140: Bundle Size — 15.76MiB (~+0.01%).Metrics (2 changes)
Total size by type (2 changes)
|
Ah sh*t. Since you tracked it down to this little change, let’s merge this PR then. |
florian-h05
approved these changes
Sep 4, 2023
@ghys FYI. Seems like there was a reason to use v-show … |
florian-h05
changed the title
Reverts v-if/v-show change from #2029.
Reverts v-if/v-show change from #2029
Sep 4, 2023
ghys
pushed a commit
that referenced
this pull request
Sep 16, 2023
Fixes #2006. With the attempt in #2029 failing due to #2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added
the
patch
A PR that has been cherry-picked to a patch release branch
label
Sep 18, 2023
florian-h05
pushed a commit
that referenced
this pull request
Sep 18, 2023
Regression from #2029. A few of my UI pages stopped loading properly. Specifically there seemed to be a condition where when the page would draw its widgets before other parts of the page were loaded (or something similar, some race conditional). This would result in widgets loading with the wrong state, colors, icons, etc that are dependent on item state. I tracked it down to this one very small change, reverting back to a `v-show` from `v-if` for the main view ready state fixes this. Signed-off-by: Dan Cunningham <dan@digitaldan.com> (cherry picked from commit 303ab55)
florian-h05
added a commit
that referenced
this pull request
Sep 18, 2023
Fixes #2006. With the attempt in #2029 failing due to #2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> (cherry picked from commit f2c008b)
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
Regression from openhab#2029. A few of my UI pages stopped loading properly. Specifically there seemed to be a condition where when the page would draw its widgets before other parts of the page were loaded (or something similar, some race conditional). This would result in widgets loading with the wrong state, colors, icons, etc that are dependent on item state. I tracked it down to this one very small change, reverting back to a `v-show` from `v-if` for the main view ready state fixes this. Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
main ui
Main UI
patch
A PR that has been cherry-picked to a patch release branch
regression
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #2029.
@florian-h05 i noticed when upgrading my system this AM that a few of my UI pages stopped loading properly. Specifically there seemed to be a condition where when the page would draw its widgets before other parts of the page were loaded ( or something similar, some race conditional). This would result in widgets loading with the wrong state, colors, icons, etc that are dependent on item state. I tracked it down to this one very small change, reverting back to a
v-show
fromv-if
for the main view ready state fixes this.