Ensure semantic model pages are built after tags are loaded #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
commented
Sep 14, 2023
| @@ -175,6 +174,12 @@ export default { | |||
| this.$store.dispatch('stopTrackingStates') | |||
| }, | |||
| onPageInit () { | |||
| this.$store.subscribe((mutation, state) => { | |||
There was a problem hiding this comment.
@ghys This could also be placed in homecards-mixin.js but it is only used by home.vue and home-edit.vue and I don't think we need this subscription for the edit page. I don`t think a user would want to update the semantic model tags and have the edit page open at the same time.
Do you agree?
Job #1157: Bundle Size — 15.76MiB (~+0.01%).Metrics (1 change)
Total size by type (2 changes)
|
ghys
approved these changes
Sep 16, 2023
|
One thing that came to my mind just a few seconds ago and that we have to keep an eye on, is that in case the home page is destroyed and re-created, the model won‘t load. I made it to only load when the tags are saved, because otherwise the model would be loaded two times on app init. |
florian-h05
added
the
patch
florian-h05
added a commit
that referenced
this pull request
Sep 18, 2023
Fixes #2006. With the attempt in #2029 failing due to #2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> (cherry picked from commit f2c008b)
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2066) Fixes openhab#2006. With the attempt in openhab#2029 failing due to openhab#2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations. This was due to a race condition, where the semantic model pages were built before the tags were loaded. This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update. Futher improvements: - Initial loading of semantic tags is put in parallel with other API requests performed on app init. - Vuex semantics: A mutation is used for setting the semantic tags from the action. - Debug logging is added to both the semantic tag and the semantic model page loading. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2006.
With the attempt in #2029 failing due to #2054, this finally fixes an issue where the semantic model pages (Equipment, Properties) were missing translations.
This was due to a race condition, where the semantic model pages were built before the tags were loaded.
This PR fixes this by watching for semantic model updates (i.e. subscripting to the underlying Vuex mutation) and loading/building the model pages after such an update.
Futher improvements: