Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-opening developer dock #2209

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

JustinGeorgi
Copy link
Contributor

Closes #2206

This will replace the auto-opening developer dock with a button on the empty overview page to open the in-app quick start tutorial. Button will only appear on pages wide enough to support the open developer dock.

@JustinGeorgi JustinGeorgi requested a review from a team as a code owner December 9, 2023 17:35
Copy link

relativeci bot commented Dec 9, 2023

Job #1304: Bundle Size — 15.82MiB (+0.34%).

01b37f1(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1304
     Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.54%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3028(+78.12%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1304
     Baseline
Job #1158
Regression  JS 9.29MiB (+0.37%) 9.25MiB
Regression  Other 4.74MiB (+0.38%) 4.73MiB
Regression  CSS 860.86KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1304 reportView JustinGeorgi:jag-autodock-fix branch activity

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I am just not sure about the wording, please have a look at my comments.

bundles/org.openhab.ui/web/src/assets/i18n/common/en.json Outdated Show resolved Hide resolved
bundles/org.openhab.ui/web/src/assets/i18n/common/de.json Outdated Show resolved Hide resolved
@JustinGeorgi
Copy link
Contributor Author

I am just not sure about the wording, please have a look at my comments.

New wording is just fine with me. My German is 20+ years out of date anyway...

JustinGeorgi and others added 2 commits December 10, 2023 20:30
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: JustinGeorgi <77952587+JustinGeorgi@users.noreply.github.com>
@florian-h05 florian-h05 merged commit 8c12108 into openhab:main Dec 11, 2023
5 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 11, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Dec 11, 2023
@florian-h05 florian-h05 added bug Something isn't working regression and removed enhancement New feature or request labels Dec 15, 2023
florian-h05 added a commit that referenced this pull request Dec 29, 2023
Follow-up for #2209.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05 added a commit that referenced this pull request Dec 29, 2023
Follow-up for #2209.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit 0f35e0e)
@JustinGeorgi JustinGeorgi deleted the jag-autodock-fix branch March 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky Developer Sidebar
2 participants