-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto-opening developer dock #2209
Conversation
Job #1304: Bundle Size — 15.82MiB (+0.34%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
Bundle size by type
View job #1304 report View JustinGeorgi:jag-autodock-fix branch activity |
36549d1
to
16a6735
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I am just not sure about the wording, please have a look at my comments.
New wording is just fine with me. My German is 20+ years out of date anyway... |
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Co-authored-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: JustinGeorgi <77952587+JustinGeorgi@users.noreply.github.com>
c91c444
to
01b37f1
Compare
Follow-up for #2209. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Closes #2206
This will replace the auto-opening developer dock with a button on the empty overview page to open the in-app quick start tutorial. Button will only appear on pages wide enough to support the open developer dock.