Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Quickstart-Button shown for non-admin users #2245

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Fix Quickstart-Button shown for non-admin users #2245

merged 1 commit into from
Dec 29, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 29, 2023 •
edited
Loading

Follow-up for #2209.

@florian-h05
Fix Quickstart-Button shown for non-admin users
50d44b9 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner December 29, 2023 22:32
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 29, 2023
@florian-h05 florian-h05 added this to the 4.2 milestone Dec 29, 2023
@relativeci RelativeCI
Copy link

relativeci bot commented Dec 29, 2023

Job #1336: Bundle Size — 15.84MiB (+0.48%).

50d44b9(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1336		      Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.81%) 1.67MiB
Regression  Initial CSS 609.75KiB(+0.14%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3033(+78.41%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1336		      Baseline
Job #1158
Regression  JS 9.31MiB (+0.54%) 9.25MiB
Regression  Other 4.75MiB (+0.5%) 4.73MiB
Regression  CSS 861.19KiB (+0.2%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1336 report View florian-h05:fix-quickstart-butto... branch activity

@florian-h05 florian-h05 merged commit 0f35e0e into openhab:main Dec 29, 2023
6 checks passed
@florian-h05 florian-h05 deleted the fix-quickstart-button-for-non-admin branch December 29, 2023 23:32
florian-h05 added a commit that referenced this pull request Dec 29, 2023
@florian-h05
Fix Quickstart-Button shown for non-admin users (#2245)
0637cc0 
Follow-up for #2209.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit 0f35e0e)
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05