Fix rule creation #999
Merged
Fix rule creation #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#998. Signed-off-by: Yannick Schaus <github@schaus.net>
Job #72: Bundle Size — 10.45MB (~-0.01%). |
hubsif
reviewed
Apr 11, 2021
| @@ -327,7 +327,8 @@ export default { | |||
| destroyOnClose: true, | |||
| closeTimeout: 2000 | |||
| }).open() | |||
| this.$f7router.navigate(this.$f7route.url.replace('/add', '/' + this.rule.uid), { reloadCurrent: true }) | |||
| this.dirty = false | |||
There was a problem hiding this comment.
Hi! Seems I missed that!
Suggesting to move that new line to line 324, which is where the save actually succeeded. That way, the new and the (misplaced) original can be merged into one.
Signed-off-by: Yannick Schaus <github@schaus.net>
Merged
ghys
added a commit
that referenced
this pull request
Apr 25, 2021
hubsif
pushed a commit
to hubsif/openhab-webui
that referenced
this pull request
May 6, 2021
Similar to openhab#999 / openhab#998. Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #998.
Signed-off-by: Yannick Schaus github@schaus.net