Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule creation #999

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Fix rule creation #999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e919a3e
Fix rule creation
ghys Apr 11, 2021
637129e
Reset dirty flag earlier
ghys Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bundles/org.openhab.ui/web/src/pages/settings/rules/rule-edit.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ export default {
destroyOnClose: true,
closeTimeout: 2000
}).open()
this.$f7router.navigate(this.$f7route.url.replace('/add', '/' + this.rule.uid), { reloadCurrent: true })
this.dirty = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Seems I missed that!
Suggesting to move that new line to line 324, which is where the save actually succeeded. That way, the new and the (misplaced) original can be merged into one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks

this.$f7router.navigate(this.$f7route.url.replace('/add', '/' + this.rule.uid).replace('/schedule/', '/rules/'), { reloadCurrent: true })
this.load()
} else {
this.$f7.toast.create({
Expand Down