-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update docs action #1633
Add update docs action #1633
Conversation
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@Confectrician why not just do it every time the docs are updated in this repo. It is pretty simple to accomplish by doing something like: on:
push:
paths:
- 'docs/**' Unless of course you are concerned about the workflow being triggered too often causing too many refresh's for our build system to handle. |
Hey @ecdye This was the procedure, I had a talk about with @mstormi before starting working on this. Please note that we are talking about the docs "stable version". Edit: So now that i am not on my phone but on a real keyboard: Build time is also a foctor that may get important at some point. Even with the open source plan of netlify (which hosts our website and docs) we have som limit for the build minutes and we already got warnings in the past, especially when we are near to an openHAB release where many builds are triggered from the openHAB Distro. We can extend the amount of events at any point, but i think per release is a good point for startign with this. |
Fair enough, I was just curious about the reasoning behind the decision. Perhaps in the future it would be better for a transparency of communication to use the GitHub Team discussions page so that all the maintainers can see and comment. |
You are totally right. I have to excuse me for this. But for completeness i have to admit that we started this talk personal on the general assembly event of the openhab foundation somw weeks ago and i just continued on that base within a community message. |
No, problem. To be honest this is a great idea and should be very useful once fully implemented. |
OK, we are ready. |
I did a test run from openhab-docs repo side and the created PR looks valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Confectrician are we ready to merge then?
Yes we are. We should verify if the trigger is working correct after merging by running the action manually. |
Worked like a charm. Thanks. :) |
This will add an action, which triggers an openhab docs repo action on an openHABian release.
(Or on a manual dispatch of this action via the Github Page.)
Depends on: openhab/openhab-docs#1690
Goal
Transfer latest openHABian documentation to the openhab docs website, when a new release has been published.
Prerequisites
docs
folderopenhabian-
docs/images
folderopenHABian-
DOCS_REPO_ACCESS_TOKEN
withpublic_repo
access to the openhab-docs repositoryWorkflow
This action will trigger a
repository_dispatch
event in the openhab-docs repository, when everything is set up correct.This event will start an action in the openhab-docs repository that fetches the latest openHABian docs contents and copy them into the stable-release openHAB documentation.
@kaikreuzer can we steup a Personal Access Token with the openhab-bot account for this?
The PAT then needs to be stored as a Secret in this repo, with the name written above.
This is needed to trigger events across different repositories.