Use HMAC from OpenSSL rather than Digest. #84
Conversation
The Digest::HMAC was an experimental implementation and has been removed from the latest Ruby version (2.2).
|
Usage of Digest::HMAC was already discouraged in Ruby 1.9.3 http://www.ruby-doc.org/stdlib-1.9.3/libdoc/digest/rdoc/Digest/HMAC.html |
Since we changed from `Digest::HMAC` to `OpenSSL::HMAC`, we should check for if `OpenSSL` is loaded, and then we can safely assume that `HMAC` is available. Before `Digest` was always defined, so we had to check if it had loaded its submodules.
|
Travis CI is failing with the Strangely, it doesn't fail on my fork https://travis-ci.org/tobiashm/ruby-openid/jobs/46293140 even though it should be the same jruby version. But I can see that the test has been run on different machines, so Travis CI might have some different configuration? |
|
Any timeline for merging this? Getting bit by this bug in trying to port an application to Ruby 2.2.0. |
|
Travis failure caused by JRuby 1.7.18. Travis will now use @dennisreimann could you please trigger Travis to restart the build? |
Use HMAC from OpenSSL rather than Digest.
Sort PLIST. ## 2.7.0 * Use RFC 2396 compatible URI parser for trustroot - 7c84ec9ced3ccbdad575e02dbfa81e53b52f909e See openid/ruby-openid#85 * Use HMAC from OpenSSL rather than Digest - ce2e30d7ff3308f17ef7d8c19d6f4752f76c9c40 See openid/ruby-openid#84 * Check if OpenSSL is loaded - 751e55820d958ee781f5abb466a576d83ddde6fd ## 2.6.0 * More safely build filenames - 1c4a90630b183e7572b8ab5f2e3a3e0c0fecd2c7 See openid/ruby-openid#80 * The session serializer of Rails4.1 is json - b44a1eb511dec3be25a07930121bc80cacec0f1c * Handle boolean value to fix signature issue - d65076269b77754da7db6e4b189edeeb9201600d See openid/ruby-openid#76
The Digest::HMAC was an experimental implementation and has been removed
from the latest Ruby version (2.2).