This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Use RFC 2396 compatible URI parser for trustroot. #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Ruby 2.2 the default
URI.parse
method uses a new RFC 3986compatible parser, which will parse most of the “invalid” URLs in the
trustroot test.
The
URI::DEFAULT_PARSER
references the “old” RFC 2396 compatibleURI parser in every version of Ruby I've tested.
Test script:
Output:
The same, using
URI.parse
instead, outputs: