8311964 : Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)

[nitinsingh130519]

This commit addresses the issue of failing jtreg tests on the x86 platform. The tests were failing due to unrecognized VM options 'LoopUnswitching', 'OptimizeFill' and 'StressCCP' which are not available in x86 binary.

Following tests were affected:

1. TestInfiniteLoopWithUnmergedBackedgesMain.java - Affected by 'LoopUnswitching'
2. TestBackedgeLoadArrayFillMain.java - Affected by 'OptimizeFill'
3. TestRangeCheckCmpUOverflowVsSub.java - Affected by 'StressCCP'

Changes have been made to these tests to avoid the use of these flags when testing on x86.

These changes maintain the integrity of the tests while ensuring compatibility across different platforms.

Related commits:

• ee63f83ed705c9cd3c49316fc4936668744f415d
• d21597aec91bbd41960923385f6a1feb31f14a0c
• e6c27925d23fe283a23c6adbe263658909c3739d

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) (Bug - P4)

Reviewers

• Dhamoder Nalla (@dhanalla - Author)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14942/head:pull/14942
$ git checkout pull/14942

Update a local copy of the PR:
$ git checkout pull/14942
$ git pull https://git.openjdk.org/jdk.git pull/14942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14942

View PR using the GUI difftool:
$ git pr show -t 14942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14942.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @nitinsingh130519, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user nitinsingh130519" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@nitinsingh130519 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a9595dab)

[TobiHartmann]

Looks good to me.

[openjdk]

@nitinsingh130519 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)

Reviewed-by: dhanalla, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 3c644dc: 8312044: Simplify toolkit Builder/Writer world
• f4ba7b2: 8312414: Make java.util.ServiceLoader.LANG_ACCESS final
• d55d7e8: 8136895: Writer not closed with disk full error, file resource leaked
• 8042a50: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout
• 84b325b: 8312182: THPs cause huge RSS due to thread start timing issue
• 842d632: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6
• 9e4fc56: 8293114: JVM should trim the native heap
• 59f66a3: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
• 8cd43bf: 8312474: JFR: Improve logging to diagnose event stream timeout
• 3e8f1eb: 8311976: Inconsistency in usage of CITimeVerbose to generate compilation logs
• ... and 18 more: https://git.openjdk.org/jdk/compare/aa23fd98f528069f5c613f43e335a0585a490176...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[nitinsingh130519]

/integrate

[openjdk]

@nitinsingh130519
Your change (at version a9595da) is now ready to be sponsored by a Committer.

[bridgekeeper]

@nitinsingh130519 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 024133b.
Since your change was applied there have been 527 commits pushed to the master branch:

• 62a953f: 8315689: G1: Remove unused init_hash_seed
• cfc1489: 8315579: SPARC64 builds are broken after JDK-8304913
• f6c203e: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API
• a01b3fb: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
• ba1a463: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• a258fc4: 8315648: Add test for JDK-8309979 changes
• 5d3fdc1: 8315612: RISC-V: intrinsic for unsignedMultiplyHigh
• 5cbff24: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• 7a08e6b: 8313575: Refactor PKCS11Test tests
• d3ee704: 8315563: Remove references to JDK-8226420 from problem list
• ... and 517 more: https://git.openjdk.org/jdk/compare/aa23fd98f528069f5c613f43e335a0585a490176...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @nitinsingh130519 Pushed as commit 024133b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.