8346193: Test runtime/ErrorHandling/TestDwarf.java fails build with clang17 #22757
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Function
frame::oops_do_internal
in src/hotspot/share/runtime/frame.cpp assign value to a nullptrchar *t
and intended to cause jvm crash. But after the assignment the nullptr do not use anymore, so clang17 consider thechar *t
initialization and assignment is "dead code". This PR addvolatile
modifier tochar *t
, to make avoid clang do the "dead code" elimination. Risk is low.Here is the example explain the "dead code" elimination.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22757/head:pull/22757
$ git checkout pull/22757
Update a local copy of the PR:
$ git checkout pull/22757
$ git pull https://git.openjdk.org/jdk.git pull/22757/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22757
View PR using the GUI difftool:
$ git pr show -t 22757
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22757.diff
Using Webrev
Link to Webrev Comment