Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346193: Test runtime/ErrorHandling/TestDwarf.java fails build with clang17 #22757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8346193: Test runtime/ErrorHandling/TestDwarf.java fails build with clang17 #22757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/runtime/frame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ void frame::oops_do_internal(OopClosure* f, NMethodClosure* cf,
#ifndef PRODUCT
// simulate GC crash here to dump java thread in error report
if (CrashGCForDumpingJavaThread) {
char *t = nullptr;
volatile char *t = nullptr; // Use volatile modifier to make clang avoid 'dead code' elimination
Copy link
Member

@dholmes-ora dholmes-ora Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
volatile char *t = nullptr; // Use volatile modifier to make clang avoid 'dead code' elimination
volatile char* t = nullptr; // Use volatile to prevent compiler from optimising away the store

*t = 'c';
}
#endif
Expand Down