8345940: Migrate security-related resources from Java classes to properties files

[artur-oracle]

These resources files are in Java classes. If converted to properties files, the localized versions can use UTF-8 encoding directly.

./src/java.base/share/classes/sun/security/tools/keytool/Resources.java
./src/java.base/share/classes/sun/security/util/Resources.java
./src/java.base/share/classes/sun/security/util/AuthResources.java
./src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8345940: Migrate security-related resources from Java classes to properties files (Enhancement - P4)

Reviewers

• Justin Lu (@justin-curtis-lu - Committer)
• Weijun Wang (@wangweij - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22774/head:pull/22774
$ git checkout pull/22774

Update a local copy of the PR:
$ git checkout pull/22774
$ git pull https://git.openjdk.org/jdk.git pull/22774/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22774

View PR using the GUI difftool:
$ git pr show -t 22774

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22774.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@artur-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345940: Migrate security-related resources from Java classes to properties files

Reviewed-by: jlu, weijun, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• da2b4f0: 8351606: Use build_platform for graphviz dependency
• 030c85d: 8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set
• 0ad9a10: 8351146: JFR: JavaMonitorInflate event should default to no threshold and be disabled
• b957e5e: 8351322: Parameterize link option for pthreads
• af9af7e: 8351145: RISC-V: only enable some crypto intrinsic when AvoidUnalignedAccess == false
• 83de340: 8343789: Move mutable nmethod data out of CodeCache
• 0de2cdd: 8351458: (ch) Move preClose to UnixDispatcher
• cd9f1d3: 8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS
• 4cf6316: 8351414: C2: MergeStores must happen after RangeCheck smearing
• 8a5ed47: 8350148: Native stack overflow when writing Java heap objects into AOT cache
• ... and 32 more: https://git.openjdk.org/jdk/compare/5cd4fe63768715ec7be32e248e05e611ea9b557d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@justin-curtis-lu, @wangweij, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@artur-oracle The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@artur-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[artur-oracle]

Work in progress, low priority.

[wangweij]

Need more reviewers from build and/or i18n.
/reviewers 2 reviewer

[openjdk]

@wangweij
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[wangweij]

/label add build

[wangweij]

/label add i18n

[openjdk]

@wangweij
The build label was successfully added.

[openjdk]

@wangweij
The i18n label was successfully added.

[justin-curtis-lu]

Skimmed some tricky values and the conversions looked correct to me.
Since it was tested that the values are the same before and after, this change looks good to me.

[erikj79]

Build changes look good. Thanks for removing this special case in the build!

[artur-oracle]

/integrate

[openjdk]

@artur-oracle
Your change (at version 7d911bc) is now ready to be sponsored by a Committer.

[wangweij]

/sponsor

[openjdk]

Going to push as commit 9a49418.
Since your change was applied there have been 44 commits pushed to the master branch:

• e71f327: 8351045: ClassValue::remove cannot ensure computation observes up-to-date state
• cef3693: 8351656: Problemlist gc/TestAllocHumongousFragment#generational
• da2b4f0: 8351606: Use build_platform for graphviz dependency
• 030c85d: 8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set
• 0ad9a10: 8351146: JFR: JavaMonitorInflate event should default to no threshold and be disabled
• b957e5e: 8351322: Parameterize link option for pthreads
• af9af7e: 8351145: RISC-V: only enable some crypto intrinsic when AvoidUnalignedAccess == false
• 83de340: 8343789: Move mutable nmethod data out of CodeCache
• 0de2cdd: 8351458: (ch) Move preClose to UnixDispatcher
• cd9f1d3: 8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS
• ... and 34 more: https://git.openjdk.org/jdk/compare/5cd4fe63768715ec7be32e248e05e611ea9b557d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij @artur-oracle Pushed as commit 9a49418.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.