8368702: [macosx] Printing text with composite fonts loses font transform #27544
+10
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing text on macOS, if the text uses a composite font (a logical font composed of more than one physical font) with a custom affine transform, the transform can be lost, and the text printed without the transform applied.
This is one of a few issues affecting the problem listed manual test
java/awt/print/PrinterJob/PrintTextTest.javaon macOS, and can be observed on page 10, on the last line ("TextLayout 2"). Without the fix, the text on this line is not stretched across the x-axis, resulting in large gaps of white space between runs of different script types.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27544/head:pull/27544$ git checkout pull/27544Update a local copy of the PR:
$ git checkout pull/27544$ git pull https://git.openjdk.org/jdk.git pull/27544/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27544View PR using the GUI difftool:
$ git pr show -t 27544Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27544.diff
Using Webrev
Link to Webrev Comment