Skip to content

8368702: [macosx] Printing text with composite fonts loses font transform #27544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −4
Open

8368702: [macosx] Printing text with composite fonts loses font transform #27544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8261a13
Avoid loss of font transform and attributes
gredler Sep 25, 2025
d3155ec
Update copyright year
gredler Sep 25, 2025
fcf7415
Add bug ID to test bug annotation
gredler Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/java.desktop/macosx/classes/sun/lwawt/macosx/CTextPipe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -97,8 +97,14 @@ private Font getSlotFont(Font font, int slot) {
if (f2d instanceof CFont) {
CompositeFont cf = ((CFont)f2d).getCompositeFont2D();
PhysicalFont pf = cf.getSlotFont(slot);
Font f = new Font(pf.getFontName(null),
font.getStyle(), font.getSize());
String name = pf.getFontName(null);
Font f = new Font(name, font.getStyle(), font.getSize());
if (font.isTransformed()) {
f = f.deriveFont(font.getTransform());
}
if (font.hasLayoutAttributes()) {
f = f.deriveFont(font.getAttributes());
}
return f;
}
return null;
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/java/awt/print/PrinterJob/PrintTextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

/*
* @test
* @bug 6425068 7156751 7157659 8029204 8132890 8148334 8344637
* @bug 6425068 7156751 7157659 8029204 8132890 8148334 8344637 8368702
* @key printer
* @summary Confirm that text prints where we expect to the length we expect.
* @library /java/awt/regtesthelpers
Expand Down