-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370368: Apply java.io.Serial annotations in java.security.jgss #27925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
|
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
| @java.io.Serial | ||
| static final long serialVersionUID = 0L; | ||
| private static final long serialVersionUID = 0L; | ||
| private final int errorCode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that private will not affect the behavior of the code.
Webrevs
|
Please review the application of the
@Serialannotation (JDK-8202385) to types in the java.security.jgss module to enable stricter compile-time checking of serialization-related declarations.Example of a similar change #24891.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27925/head:pull/27925$ git checkout pull/27925Update a local copy of the PR:
$ git checkout pull/27925$ git pull https://git.openjdk.org/jdk.git pull/27925/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27925View PR using the GUI difftool:
$ git pr show -t 27925Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27925.diff
Using Webrev
Link to Webrev Comment