8355004: Apply java.io.Serial annotations in java.compiler

[mrserb]

Please review the application of @Serial annotation (JDK-8202385) to types in the compiler module to enable stricter compile-time checking of serialization-related declarations. Just a few classes are covered.

This annotation can be applied to these methods in the module:

private void writeObject(java.io.ObjectOutputStream stream) throws IOException
private void readObject(java.io.ObjectInputStream stream) throws IOException, ClassNotFoundException
private void readObjectNoData() throws ObjectStreamException
ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
private static final ObjectStreamField[] serialPersistentFields
private static final long serialVersionUID

Any feedback or suggestions are welcome!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355004: Apply java.io.Serial annotations in java.compiler (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24891/head:pull/24891
$ git checkout pull/24891

Update a local copy of the PR:
$ git checkout pull/24891
$ git pull https://git.openjdk.org/jdk.git pull/24891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24891

View PR using the GUI difftool:
$ git pr show -t 24891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24891.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355004: Apply java.io.Serial annotations in java.compiler

Reviewed-by: liach, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 64503c7: 8357299: Graphics copyArea doesn't copy any pixels when there is overflow
• a05f9de: 8358017: Various enhancements of jpackage test helpers
• 648c337: 8356648: runtime/Thread/AsyncExceptionTest.java fails with +StressCompiledExceptionHandlers
• ... and 6 more: https://git.openjdk.org/jdk/compare/79aff26c2880922b92863911d8a5a035ba9a1e75...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9dfe7802)
• 00: Full (af94d056)

[liach]

Hmm, was there no compiler warning from the lack of serial annotations?

[mrserb]

Hmm, was there no compiler warning from the lack of serial annotations?

There is no compiler warning currently, even with -Xlint:serial.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[liach]

I think this addition looks fine. Please wait till next week for someone else to review too.

[mrserb]

/integrate

[openjdk]

Going to push as commit 5ad02c9.
Since your change was applied there have been 34 commits pushed to the master branch:

• 2926435: 8341346: Add support for exporting TLS Keying Material
• 0df8c96: 8353686: Optimize Math.cbrt for x86 64 bit platforms
• db340e5: 8356222: Thread.print command reports waiting on the Class initialization monitor for both carrier and virtual threads
• ... and 31 more: https://git.openjdk.org/jdk/compare/79aff26c2880922b92863911d8a5a035ba9a1e75...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 5ad02c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.