8361533: Apply java.io.Serial annotations in java.logging

[mrserb]

Please review the application of the @Serial annotation (JDK-8202385) to types in the java.logging module to enable stricter compile-time checking of serialization-related declarations. Only one class remains to be covered; all other relevant fields and methods are already annotated with @Serial.

This annotation can be applied to these methods in the module:

private void writeObject(java.io.ObjectOutputStream stream) throws IOException
private void readObject(java.io.ObjectInputStream stream) throws IOException, ClassNotFoundException
private void readObjectNoData() throws ObjectStreamException
ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
private static final ObjectStreamField[] serialPersistentFields
private static final long serialVersionUID

Example of a similar change in the java.compiler module.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361533: Apply java.io.Serial annotations in java.logging (Enhancement - P4)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26208/head:pull/26208
$ git checkout pull/26208

Update a local copy of the PR:
$ git checkout pull/26208
$ git pull https://git.openjdk.org/jdk.git pull/26208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26208

View PR using the GUI difftool:
$ git pr show -t 26208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26208.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361533: Apply java.io.Serial annotations in java.logging

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e6c35899)
• 00: Full (9d4f1153)

[AlanBateman]

This is okay but just to point out that the SecurityManager feature is disabled completely since JDK 24 and LoggingPermission is deprecated for removal. So unlikely that new code will make use of this.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

/keepalive

[openjdk]

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

[mrserb]

Looking for volunteers to review this trivial patch.

[RogerRiggs]

Looks good; trivial.

[mrserb]

/integrate

[openjdk]

Going to push as commit 14a40fd.
Since your change was applied there have been 2 commits pushed to the master branch:

• 6bb15a5: 8367035: [BACKOUT] Protect ExecuteWithLog from running with redirection without a subshell
• e8c7d2a: 8332872: SetupExecute should cd to temp directory

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 14a40fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.