Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8252887: Zero VM is broken after JDK-8252661 #64

Closed
wants to merge 1 commit into from
Closed

8252887: Zero VM is broken after JDK-8252661 #64

wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 7, 2020 •
edited by openjdk bot
Loading

Hi all,

JBS: https://bugs.openjdk.java.net/browse/JDK-8252887

Zero VM is broken due to 'block_if_requested' is not a member of 'SafepointMechanism'.
The reason is that 'block_if_requested' has been replaced by 'process_if_requested' after JDK-8252661.

The fix just replaces 'block_if_requested' with 'process_if_requested'.

Thanks.
Best regards,
Jie

/issue add DK-8252887
/cc hotspot-runtime
/test
/summary
8252887: Zero VM is broken after JDK-8252661

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/64/head:pull/64
$ git checkout pull/64

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@DamonFool The issue identifier DK-8252887 is invalid: This PR can only solve issues in the JDK project.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@DamonFool
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@DamonFool Setting summary to 8252887: Zero VM is broken after JDK-8252661

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@DamonFool To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

@DamonFool
Copy link
Member Author

/label add hotspot-runtime
/issue add JDK-8252887
/cc hotspot-runtime

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@DamonFool The hotspot-runtime label was already applied.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@DamonFool The hotspot-runtime label was already applied.

dholmes-ora
dholmes-ora approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020 •
edited
Loading

@DamonFool This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252887: Zero VM is broken after JDK-8252661

Zero VM is broken due to 'block_if_requested' is not a member of 'SafepointMechanism'.

Reviewed-by: dholmes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 7686e871551c745f062f084eaaae594c857066c0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2020
@DamonFool
Copy link
Member Author

/summary Zero VM is broken due to 'block_if_requested' is not a member of 'SafepointMechanism'.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@DamonFool Updating existing summary to Zero VM is broken due to 'block_if_requested' is not a member of 'SafepointMechanism'.

@DamonFool
Copy link
Member Author

Thanks David for your review.

@DamonFool
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@DamonFool Pushed as commit 891886b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 8, 2020
@DamonFool DamonFool deleted the JDK-8252887 branch September 8, 2020 03:00
@mlbridge mlbridge bot mentioned this pull request Nov 9, 2020
Closed
3 tasks
lewurm added a commit to lewurm/openjdk that referenced this pull request Oct 6, 2021
@lewurm
remove pusha/popa, be explicit in the template generator
84c5c90 
Restore looks like this now:
```
  0x0000000106e4dfcc:   movk    x9, #0x5e4, lsl openjdk#16
  0x0000000106e4dfd0:   movk    x9, #0x1, lsl openjdk#32
  0x0000000106e4dfd4:   blr x9
  0x0000000106e4dfd8:   ldp x2, x3, [sp, openjdk#16]
  0x0000000106e4dfdc:   ldp x4, x5, [sp, openjdk#32]
  0x0000000106e4dfe0:   ldp x6, x7, [sp, openjdk#48]
  0x0000000106e4dfe4:   ldp x8, x9, [sp, openjdk#64]
  0x0000000106e4dfe8:   ldp x10, x11, [sp, openjdk#80]
  0x0000000106e4dfec:   ldp x12, x13, [sp, openjdk#96]
  0x0000000106e4dff0:   ldp x14, x15, [sp, openjdk#112]
  0x0000000106e4dff4:   ldp x16, x17, [sp, openjdk#128]
  0x0000000106e4dff8:   ldp x0, x1, [sp], openjdk#144
  0x0000000106e4dffc:   ldp xzr, x19, [sp], openjdk#16
  0x0000000106e4e000:   ldp x22, x23, [sp, openjdk#16]
  0x0000000106e4e004:   ldp x24, x25, [sp, openjdk#32]
  0x0000000106e4e008:   ldp x26, x27, [sp, openjdk#48]
  0x0000000106e4e00c:   ldp x28, x29, [sp, openjdk#64]
  0x0000000106e4e010:   ldp x30, xzr, [sp, openjdk#80]
  0x0000000106e4e014:   ldp x20, x21, [sp], openjdk#96
  0x0000000106e4e018:   ldur    x12, [x29, #-24]
  0x0000000106e4e01c:   ldr x22, [x12, openjdk#16]
  0x0000000106e4e020:   add x22, x22, #0x30
  0x0000000106e4e024:   ldr x8, [x28, openjdk#8]
```
caojoshua added a commit to caojoshua/jdk that referenced this pull request Jul 28, 2023
@caojoshua
[PEA] mark monitor inputs as escaped (openjdk#64)
b8e8eb2
dansmithcode pushed a commit to dansmithcode/jdk that referenced this pull request Aug 31, 2024
@lkuskov
7903546: jdec,jdis: Enhance decompiler outputs flexibility and readab…
944d9b7 
…ility. (openjdk#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholmes-ora dholmes-ora dholmes-ora approved these changes

Assignees
No one assigned
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamonFool @dholmes-ora