Class value null initial cache array #8

plevart · 2020-08-15T08:54:46Z

null initial cacheArray in ClassValueMap

bridgekeeper · 2020-08-15T08:55:30Z

Welcome to the OpenJDK organization on GitHub!

This repository is currently a read-only git mirror of the official Mercurial repository (located at https://hg.openjdk.java.net/). As such, we are not currently accepting pull requests here. If you would like to contribute to the OpenJDK project, please see https://openjdk.java.net/contribute/ on how to proceed.

This pull request will be automatically closed.

Reviewed-by: valeriep

Address More Review comments

Restore looks like this now: ``` 0x0000000106e4dfcc: movk x9, #0x5e4, lsl openjdk#16 0x0000000106e4dfd0: movk x9, #0x1, lsl openjdk#32 0x0000000106e4dfd4: blr x9 0x0000000106e4dfd8: ldp x2, x3, [sp, openjdk#16] 0x0000000106e4dfdc: ldp x4, x5, [sp, openjdk#32] 0x0000000106e4dfe0: ldp x6, x7, [sp, openjdk#48] 0x0000000106e4dfe4: ldp x8, x9, [sp, openjdk#64] 0x0000000106e4dfe8: ldp x10, x11, [sp, openjdk#80] 0x0000000106e4dfec: ldp x12, x13, [sp, openjdk#96] 0x0000000106e4dff0: ldp x14, x15, [sp, openjdk#112] 0x0000000106e4dff4: ldp x16, x17, [sp, openjdk#128] 0x0000000106e4dff8: ldp x0, x1, [sp], openjdk#144 0x0000000106e4dffc: ldp xzr, x19, [sp], openjdk#16 0x0000000106e4e000: ldp x22, x23, [sp, openjdk#16] 0x0000000106e4e004: ldp x24, x25, [sp, openjdk#32] 0x0000000106e4e008: ldp x26, x27, [sp, openjdk#48] 0x0000000106e4e00c: ldp x28, x29, [sp, openjdk#64] 0x0000000106e4e010: ldp x30, xzr, [sp, openjdk#80] 0x0000000106e4e014: ldp x20, x21, [sp], openjdk#96 0x0000000106e4e018: ldur x12, [x29, #-24] 0x0000000106e4e01c: ldr x22, [x12, openjdk#16] 0x0000000106e4e020: add x22, x22, #0x30 0x0000000106e4e024: ldr x8, [x28, openjdk#8] ```

This patch optimizes the backend implementation of VectorMaskToLong for AArch64, given a more efficient approach to mov value bits from predicate register to general purpose register as x86 PMOVMSK[1] does, by using BEXT[2] which is available in SVE2. With this patch, the final code (input mask is byte type with SPECIESE_512, generated on an SVE vector reg size of 512-bit QEMU emulator) changes as below: Before: mov z16.b, p0/z, #1 fmov x0, d16 orr x0, x0, x0, lsr openjdk#7 orr x0, x0, x0, lsr openjdk#14 orr x0, x0, x0, lsr openjdk#28 and x0, x0, #0xff fmov x8, v16.d[1] orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#8 orr x8, xzr, #0x2 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#16 orr x8, xzr, #0x3 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#24 orr x8, xzr, #0x4 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#32 mov x8, #0x5 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#40 orr x8, xzr, #0x6 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#48 orr x8, xzr, #0x7 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#56 After: mov z16.b, p0/z, #1 mov z17.b, #1 bext z16.d, z16.d, z17.d mov z17.d, #0 uzp1 z16.s, z16.s, z17.s uzp1 z16.h, z16.h, z17.h uzp1 z16.b, z16.b, z17.b mov x0, v16.d[0] [1] https://www.felixcloutier.com/x86/pmovmskb [2] https://developer.arm.com/documentation/ddi0602/2020-12/SVE-Instructions/BEXT--Gather-lower-bits-from-positions-selected-by-bitmask- Change-Id: Ia983a20c89f76403e557ac21328f2f2e05dd08e0

…penjdk#8) Reviewed-by: mbalao

After JDK-8283091, the loop below can be vectorized partially. Statement 1 can be vectorized but statement 2 can't. ``` // int[] iArr; long[] lArrFld; int i1,i2; for (i1 = 6; i1 < 227; i1++) { iArr[i1] += lArrFld[i1]++; // statement 1 iArr[i1 + 1] -= (i2++); // statement 2 } ``` But we got incorrect results because the vector packs of iArr are scheduled incorrectly like: ``` ... load_vector XMM1,[R8 + openjdk#16 + R11 << openjdk#2] movl RDI, [R8 + openjdk#20 + R11 << openjdk#2] # int load_vector XMM2,[R9 + openjdk#8 + R11 << openjdk#3] subl RDI, R11 # int vpaddq XMM3,XMM2,XMM0 ! add packedL store_vector [R9 + openjdk#8 + R11 << openjdk#3],XMM3 vector_cast_l2x XMM2,XMM2 ! vpaddd XMM1,XMM2,XMM1 ! add packedI addl RDI, openjdk#228 # int movl [R8 + openjdk#20 + R11 << openjdk#2], RDI # int movl RBX, [R8 + openjdk#24 + R11 << openjdk#2] # int subl RBX, R11 # int addl RBX, openjdk#227 # int movl [R8 + openjdk#24 + R11 << openjdk#2], RBX # int ... movl RBX, [R8 + openjdk#40 + R11 << openjdk#2] # int subl RBX, R11 # int addl RBX, openjdk#223 # int movl [R8 + openjdk#40 + R11 << openjdk#2], RBX # int movl RDI, [R8 + openjdk#44 + R11 << openjdk#2] # int subl RDI, R11 # int addl RDI, openjdk#222 # int movl [R8 + openjdk#44 + R11 << openjdk#2], RDI # int store_vector [R8 + openjdk#16 + R11 << openjdk#2],XMM1 ... ``` simplified as: ``` load_vector iArr in statement 1 unvectorized loads/stores in statement 2 store_vector iArr in statement 1 ``` We cannot pick the memory state from the first load for LoadI pack here, as the LoadI vector operation must load the new values in memory after iArr writes 'iArr[i1 + 1] - (i2++)' to 'iArr[i1 + 1]'(statement 2). We must take the memory state of the last load where we have assigned new values ('iArr[i1 + 1] - (i2++)') to the iArr array. In JDK-8240281, we picked the memory state of the first load. Different from the scenario in JDK-8240281, the store, which is dependent on an earlier load here, is in a pack to be scheduled and the LoadI pack depends on the last_mem. As designed[2], to schedule the StoreI pack, all memory operations in another single pack should be moved in the same direction. We know that the store in the pack depends on one of loads in the LoadI pack, so the LoadI pack should be scheduled before the StoreI pack. And the LoadI pack depends on the last_mem, so the last_mem must be scheduled before the LoadI pack and also before the store pack. Therefore, we need to take the memory state of the last load for the LoadI pack here. To fix it, the pack adds additional checks while picking the memory state of the first load. When the store locates in a pack and the load pack relies on the last_mem, we shouldn't choose the memory state of the first load but choose the memory state of the last load. [1]https://github.com/openjdk/jdk/blob/0ae834105740f7cf73fe96be22e0f564ad29b18d/src/hotspot/share/opto/superword.cpp#L2380 [2]https://github.com/openjdk/jdk/blob/0ae834105740f7cf73fe96be22e0f564ad29b18d/src/hotspot/share/opto/superword.cpp#L2232 Jira: ENTLLT-5482 Change-Id: I341d10b91957b60a1b4aff8116723e54083a5fb8 CustomizedGitHooks: yes

…njdk#8) Enforce position-independent materialization. We double down JVMState/SafepointNode from the original AllocateNode. This ensures that materialization isn't dependent on current JVMState. Co-authored-by: Xin Liu <xxinliu@amazon.com>

…penjdk#8) Reviewed-by: mbalao

… now. See Test : openjdk#8, WithAOT (with loop) for "LIT" + (String)b in PrelinkedStringConcat.java

…penjdk#8) Reviewed-by: mbalao

…ng into ldp/stp on AArch64 Macro-assembler on aarch64 can merge adjacent loads or stores into ldp/stp[1]. For example, it can merge: ``` str w20, [sp, openjdk#16] str w10, [sp, openjdk#20] ``` into ``` stp w20, w10, [sp, openjdk#16] ``` But C2 may generate a sequence like: ``` str x21, [sp, openjdk#8] str w20, [sp, openjdk#16] str x19, [sp, openjdk#24] <--- str w10, [sp, openjdk#20] <--- Before sorting str x11, [sp, openjdk#40] str w13, [sp, openjdk#48] str x16, [sp, openjdk#56] ``` We can't do any merging for non-adjacent loads or stores. The patch is to sort the spilling or unspilling sequence in the order of offset during instruction scheduling and bundling phase. After that, we can get a new sequence: ``` str x21, [sp, openjdk#8] str w20, [sp, openjdk#16] str w10, [sp, openjdk#20] <--- str x19, [sp, openjdk#24] <--- After sorting str x11, [sp, openjdk#40] str w13, [sp, openjdk#48] str x16, [sp, openjdk#56] ``` Then macro-assembler can do ld/st merging: ``` str x21, [sp, openjdk#8] stp w20, w10, [sp, openjdk#16] <--- Merged str x19, [sp, openjdk#24] str x11, [sp, openjdk#40] str w13, [sp, openjdk#48] str x16, [sp, openjdk#56] ``` To justify the patch, we run `HelloWorld.java` ``` public class HelloWorld { public static void main(String [] args) { System.out.println("Hello World!"); } } ``` with `java -Xcomp -XX:-TieredCompilation HelloWorld`. Before the patch, macro-assembler can do ld/st merging for 3688 times. After the patch, the number of ld/st merging increases to 3871 times, by ~5 %. Tested tier1~3 on x86 and AArch64. [1] https://github.com/openjdk/jdk/blob/a95062b39a431b4937ab6e9e73de4d2b8ea1ac49/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L2079

SerializationHostileMethod

Simplify, erase, remove ClassOption.STRONG

plevart added 2 commits August 15, 2020 10:20

null initial cache in ClassValueMap

31bef6f

remove redundant initialization of cache

fc6a6a1

bridgekeeper bot closed this Aug 15, 2020

ameisen referenced this pull request in ameisen/jdk-mc Sep 7, 2020

8244565: Accept PKCS #8 with version number 1

507816d

Reviewed-by: valeriep

mlbridge bot mentioned this pull request Oct 27, 2020

8255246: AArch64: Implement BigInteger shiftRight and shiftLeft accelerator/intrinsic #861

Closed

3 tasks

gerard-ziemski mentioned this pull request Nov 2, 2020

8253742: POSIX signal code cleanup #636

Closed

3 tasks

JornVernee referenced this pull request in JornVernee/jdk Nov 14, 2020

Merge pull request #8 from JornVernee/Vlad_Comments

739c792

Address More Review comments

stefank mentioned this pull request May 3, 2021

8266432: ZGC: GC allocation stalls can trigger deadlocks #3839

Closed

3 tasks

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Jun 22, 2022

RH2036462: sun.security.pkcs11.wrapper.PKCS11.getInstance breakage (o…

1e55dec

…penjdk#8) Reviewed-by: mbalao

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Jun 22, 2022

RH2036462: sun.security.pkcs11.wrapper.PKCS11.getInstance breakage (o…

e9772be

…penjdk#8) Reviewed-by: mbalao

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Jul 10, 2022

RH2036462: sun.security.pkcs11.wrapper.PKCS11.getInstance breakage (o…

4479766

…penjdk#8) Reviewed-by: mbalao

wangweij mentioned this pull request Sep 1, 2022

5066842: PKCS8EncodedKeySpec needs getAlgorithm method #10131

Closed

4 tasks

kevinjwalls mentioned this pull request Nov 14, 2022

8296709: WARNING: JNI call made without checking exceptions #11083

Closed

3 tasks

JimLaskey pushed a commit to JimLaskey/jdk that referenced this pull request Nov 16, 2022

Requested changes openjdk#8

dcceb67

JimLaskey pushed a commit to JimLaskey/jdk that referenced this pull request Nov 16, 2022

Requested changes openjdk#8

2edc792

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Mar 31, 2023

RH2036462: sun.security.pkcs11.wrapper.PKCS11.getInstance breakage (o…

0290b62

…penjdk#8) Reviewed-by: mbalao

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Mar 31, 2023

RH2036462: sun.security.pkcs11.wrapper.PKCS11.getInstance breakage (o…

bc4845f

…penjdk#8) Reviewed-by: mbalao

iklam added a commit to veresov/jdk that referenced this pull request Jun 21, 2023

AOT of ConcatA.loopa() can compile through the invikedynamic callsite…

854571a

… now. See Test : openjdk#8, WithAOT (with loop) for "LIT" + (String)b in PrelinkedStringConcat.java

robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023

Extract version number for package (openjdk#8)

4e12331

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Aug 18, 2023

RH2036462: sun.security.pkcs11.wrapper.PKCS11.getInstance breakage (o…

c7a932d

…penjdk#8) Reviewed-by: mbalao

mmyxym mentioned this pull request Dec 25, 2023

8305895: Implementation: JEP 450: Compact Object Headers (Experimental) #13961

Closed

20 tasks

jatin-bhateja pushed a commit to jatin-bhateja/jdk that referenced this pull request Mar 4, 2024

fix rex2 map1 M0 and opcode 0x0F prefix bugs (openjdk#8)

272e0e6

This was referenced Apr 29, 2024

8331298: avoid alignment checks in UBSAN enabled build #18998

Closed

8331428: ubsan: JVM flag checking complains about MaxTenuringThresholdConstraintFunc, InitialTenuringThresholdConstraintFunc and AllocatePrefetchStepSizeConstraintFunc #19074

Closed

MBaesken mentioned this pull request Jun 12, 2024

8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' #19677

Closed

3 tasks

openjdk-notifier bot pushed a commit that referenced this pull request Jun 18, 2024

Merge pull request #8 from cl4es/serialization_hostile

d336748

SerializationHostileMethod

MBaesken mentioned this pull request Jul 24, 2024

8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' #20296

Closed

3 tasks

openjdk-notifier bot pushed a commit that referenced this pull request Jul 31, 2024

Merge pull request #8 from cl4es/pr_20273_fixes

f897301

Simplify, erase, remove ClassOption.STRONG

MBaesken mentioned this pull request Aug 16, 2024

8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero #20615

Closed

3 tasks

MBaesken mentioned this pull request Sep 6, 2024

8339648: ZGC: Division by zero in rule_major_allocation_rate #20888

Closed

3 tasks

MBaesken mentioned this pull request Oct 1, 2024

8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask' #21288

Closed

3 tasks

hns mentioned this pull request Oct 24, 2024

8305406: Add @spec tags in java.base/java.* (part 2) #21326

Closed

3 tasks

MBaesken mentioned this pull request Oct 24, 2024

8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask' #21684

Closed

3 tasks

MBaesken mentioned this pull request Dec 6, 2024

8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64 #22603

Closed

3 tasks

MBaesken mentioned this pull request Jan 3, 2025

8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64 #22910

Closed

3 tasks

wangweij mentioned this pull request Jan 30, 2025

8347938: Switch to latest ML-KEM private key encoding #23376

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class value null initial cache array #8

Class value null initial cache array #8

plevart commented Aug 15, 2020

bridgekeeper bot commented Aug 15, 2020

Class value null initial cache array #8

Class value null initial cache array #8

Conversation

plevart commented Aug 15, 2020

bridgekeeper bot commented Aug 15, 2020