-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir #542
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
The GHA report several failures.
|
/approval request Similar to JDK-8309138, fix SupplementalJapaneseEraTest.java for jdk with symlinked conf dir (such as fedora/rhel packages). |
@sendaoYan |
/approval request Similar to JDK-8309138, fix SupplementalJapaneseEraTest.java for jdk with symlinked conf dir (such as fedora/rhel packages). Only change the testcase, the change has been verified, no risk. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Can anyone take look this PR |
Thanks all for the approved and review. |
@sendaoYan |
/sponsor |
Going to push as commit fb0a658.
Your commit was automatically rebased without conflicts. |
@mrserb @sendaoYan Pushed as commit fb0a658. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for the sponsor. |
Hi all,
Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
This is similar to JDK-8309138.
Only change the testcase, the change has been verified, no risk.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/542/head:pull/542
$ git checkout pull/542
Update a local copy of the PR:
$ git checkout pull/542
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/542/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 542
View PR using the GUI difftool:
$ git pr show -t 542
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/542.diff
Webrev
Link to Webrev Comment