Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir #542

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 8, 2024

Hi all,
Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
This is similar to JDK-8309138.
Only change the testcase, the change has been verified, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335894 needs maintainer approval

Issue

  • JDK-8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/542/head:pull/542
$ git checkout pull/542

Update a local copy of the PR:
$ git checkout pull/542
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 542

View PR using the GUI difftool:
$ git pr show -t 542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/542.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 15, 2024

The GHA report several failures.

  1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3
  1. Linux x86 gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java report timeout failure, I have create a issue JDK-8336400 to record this failure, I think it's unrelated to this PR.
  2. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

@sendaoYan
Copy link
Member Author

/approval request Similar to JDK-8309138, fix SupplementalJapaneseEraTest.java for jdk with symlinked conf dir (such as fedora/rhel packages).

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

@sendaoYan
8335894: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 15, 2024
@sendaoYan
Copy link
Member Author

/approval request Similar to JDK-8309138, fix SupplementalJapaneseEraTest.java for jdk with symlinked conf dir (such as fedora/rhel packages). Only change the testcase, the change has been verified, no risk.

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

@sendaoYan
8335894: The approval request has been updated successfully.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Can anyone take look this PR

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 16, 2024
@sendaoYan
Copy link
Member Author

Thanks all for the approved and review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 16, 2024
@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@sendaoYan
Your change (at version 41b38a7) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Aug 16, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

Going to push as commit fb0a658.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2024
@openjdk openjdk bot closed this Aug 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 16, 2024
@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@mrserb @sendaoYan Pushed as commit fb0a658.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8335894 branch August 17, 2024 10:59
@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants