-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334441: Mark tests in jdk_security_infra group as manual #526
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk. |
@sendaoYan |
The GHA test runner report several failures, all the failures was recorded by JDK-8334732, unralated to this PR.
|
No, because it's With JDK-8315757, we added /approval no |
@gnu-andrew Only the author (@sendaoYan) is allowed to issue the |
/approve no |
@gnu-andrew |
It looks like JDK-8030204 was pushed after you created your fork. This should now be fixed. |
Thanks for the remind. I have merged the fixed in this PR. |
Sorry, I didn't describe the problem accurately. The file rename from |
|
The GHA test runner report a failure, I think it's unrelated to this PR.
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@sendaoYan This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
@wkia Only the pull request author can set the pull request state to "open" |
I'd like to see this integrated. @sendaoYan will you continue waiting for review approval? |
I am not quite sure that does this PR needed to integrated or not. |
It'd help with running jtreg tests on jdk8. Currently these tests fail if running the complete bundle like tier1 or whatever. |
Hi all,
This pull request contains a backport of commit 1e3e6877 from the openjdk/jdk11u repository.
The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr.
The file rename from
jdk/test/TEST.groups
totest/jdk/TEST.groups
by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly.Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/526/head:pull/526
$ git checkout pull/526
Update a local copy of the PR:
$ git checkout pull/526
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/526/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 526
View PR using the GUI difftool:
$ git pr show -t 526
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/526.diff
Webrev
Link to Webrev Comment