Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244966: Add .vscode to .hgignore and .gitignore #556

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 30, 2024

Hi all,

This pull request contains a backport of commit 95c0b97b from the openjdk/jdk11u-dev repository.

The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.

Trivial fix but useful, no risk.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8244966 needs maintainer approval

Issue

  • JDK-8244966: Add .vscode to .hgignore and .gitignore (Enhancement - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/556/head:pull/556
$ git checkout pull/556

Update a local copy of the PR:
$ git checkout pull/556
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 556

View PR using the GUI difftool:
$ git pr show -t 556

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/556.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 30, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 95c0b97bc2bfcb686dfabc6d74424772f0f866a1 8244966: Add .vscode to .hgignore and .gitignore Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 30, 2024
@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix but useful, no risk.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@sendaoYan
8244966: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 30, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi all, does this backport useful to jdk8u-dev.

@sendaoYan
Copy link
Member Author

The GHA report several failures, all the failures are unreleated to this PR.

  1. windows x86 build fails _isnan referenced in function _checkOverflow which has been recorded and fixed by JDK-8337312
  2. macosx-64 jdk/tier1 report com/sun/jdi tests fails, transport error 202: gethostbyname: unknown host seems to be GHA environmental issue.
  3. macos-x64 hotpsot/tier1 report OpaqueAccesses.java fails, which has been recorded by JDK-8337185
  4. macos-x64 hotpsot/tier1 report FieldMonitor.java fails, same to 2
  5. All the fails are CA test fails, which fixing by 8334441: Mark tests in jdk_security_infra group as manual #526

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

1 similar comment
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix but useful, no risk.

@openjdk
Copy link

openjdk bot commented Oct 31, 2024

@sendaoYan
8244966: The approval request was already up to date.

@sendaoYan
Copy link
Member Author

I think it's not quite strong necessary to backport this PR, sorry for the interrupt.

@sendaoYan sendaoYan closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant