-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8244966: Add .vscode to .hgignore and .gitignore #556
8244966: Add .vscode to .hgignore and .gitignore #556
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue and summary from the original commit. |
|
/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix but useful, no risk. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi all, does this backport useful to jdk8u-dev. |
The GHA report several failures, all the failures are unreleated to this PR.
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
1 similar comment
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix but useful, no risk. |
@sendaoYan |
I think it's not quite strong necessary to backport this PR, sorry for the interrupt. |
Hi all,
This pull request contains a backport of commit 95c0b97b from the openjdk/jdk11u-dev repository.
The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
Trivial fix but useful, no risk.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/556/head:pull/556
$ git checkout pull/556
Update a local copy of the PR:
$ git checkout pull/556
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/556/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 556
View PR using the GUI difftool:
$ git pr show -t 556
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/556.diff
Webrev
Link to Webrev Comment