Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335978: [8u] incorrect include file name in semaphore.inline.hpp #543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 9, 2024

Hi all,
In file semaphore.inline.hpp, #include "runtime/interfaceSupport.inline.hpp" include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository.

Additional testing:

  • linux x64 tier1/2/3
  • linux aarch64 tier1/2/3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335978 needs maintainer approval

Issue

  • JDK-8335978: [8u] incorrect include file name in semaphore.inline.hpp (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/543/head:pull/543
$ git checkout pull/543

Update a local copy of the PR:
$ git checkout pull/543
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 543

View PR using the GUI difftool:
$ git pr show -t 543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/543.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 15, 2024

The GHA report several failures.

  1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3
  1. Linux x86 gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java report timeout failure, I have create a issue JDK-8336400 to record this failure, I think it's unrelated to this PR.
  2. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

@sendaoYan
Copy link
Member Author

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

@sendaoYan
8335978: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 15, 2024
@phohensee
Copy link
Member

phohensee commented Jul 19, 2024

interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated.

@sendaoYan
Copy link
Member Author

interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated.

Thanks for the review.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval cancel

@openjdk
Copy link

openjdk bot commented Aug 17, 2024

@sendaoYan
8335978: The approval request has been cancelled successfully.

@sendaoYan
Copy link
Member Author

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

1 similar comment
@sendaoYan
Copy link
Member Author

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

@openjdk
Copy link

openjdk bot commented Aug 17, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval label Aug 17, 2024
@openjdk
Copy link

openjdk bot commented Aug 17, 2024

@sendaoYan
8335978: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Aug 17, 2024

@sendaoYan
8335978: The approval request was already up to date.

@openjdk openjdk bot added the approval label Aug 17, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Fix incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

@openjdk
Copy link

openjdk bot commented Sep 14, 2024

@sendaoYan
8335978: The approval request has been updated successfully.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 12, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Nov 9, 2024

@sendaoYan
8335978: The approval request has been updated successfully.

@sendaoYan
Copy link
Member Author

/approval request Fix incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

@openjdk
Copy link

openjdk bot commented Nov 9, 2024

@sendaoYan
8335978: The approval request has been updated successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants