Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Sep 14, 2024

Hi all,
We observerd the test sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java intermittent fails on jdk8u-dev. The failure phenomenon samt to JDK-8228658. So I want to backport this PR from jdk11u-dev to jdk8u-dev.

Only the copyright year backported not cleanly, the copyright year modified by JDK-6719955 and JDK-6943119 in jdk8u-dev. Other parts are backport cleanly.

The change has been verified locally, make the test more robustness, test fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8228658 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/578/head:pull/578
$ git checkout pull/578

Update a local copy of the PR:
$ git checkout pull/578
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 578

View PR using the GUI difftool:
$ git pr show -t 578

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/578.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c4e0c2656caaba67128f75d733b4452def9a7afc 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms Sep 14, 2024
@openjdk
Copy link

openjdk bot commented Sep 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 14, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2024

Webrevs

@sendaoYan
Copy link
Member Author

The GHA report several failures, all the failures unreleated to this PR.

  1. linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
  2. linux x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
  3. linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
  4. windows x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
  5. windows x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
  6. macos x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
  7. macos x64 hotspot/tier1 compiler/unsafe/OpaqueAccesses.java test fails, which has been recorded by JDK-8337185, it's unreleated to this PR.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 12, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Nov 9, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Dec 8, 2024

@sendaoYan This pull request is already open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants