Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: prysm: A Python optics module #1339

Closed
whedon opened this issue Mar 20, 2019 · 24 comments
Closed

[PRE REVIEW]: prysm: A Python optics module #1339

whedon opened this issue Mar 20, 2019 · 24 comments

Comments

@whedon
Copy link

whedon commented Mar 20, 2019

Submitting author: @brandondube (Brandon Dube)
Repository: https://github.com/brandondube/prysm
Version: v0.15.1
Editor: @xuanxu
Reviewers: @aquilesC

Author instructions

Thanks for submitting your paper to JOSS @brandondube. Currently, there isn't an JOSS editor assigned to your paper.

@brandondube if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 20, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Mar 20, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 20, 2019

PDF failed to compile for issue #1339 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 13 0 13 0 0 114 0 --:--:-- --:--:-- --:--:-- 115
Could not find bibliography file: paper.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@arfon
Copy link
Member

arfon commented Mar 20, 2019

@brandondube - please either rename references.bib to be paper.bib or change the entry in your paper.md to point to references.bib

@brandondube
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Mar 21, 2019

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

@brandondube
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 21, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 21, 2019

@brandondube
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 24, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 24, 2019

@danielskatz
Copy link

👋 @xuanxu - Would you be willing to edit this submission?

@xuanxu
Copy link
Member

xuanxu commented Mar 27, 2019

@danielskatz sure!

@xuanxu
Copy link
Member

xuanxu commented Mar 27, 2019

@whedon assign @xuanxu as editor

@whedon
Copy link
Author

whedon commented Mar 27, 2019

OK, the editor is @xuanxu

@xuanxu
Copy link
Member

xuanxu commented Mar 28, 2019

👋 @aquilesC: Would you be willing to review this paper? I think your expertise in Python and Optics makes you a great fit for this submission.

@aquilesC
Copy link

@xuanxu , sure!

@xuanxu
Copy link
Member

xuanxu commented Mar 29, 2019

Great! Thanks @aquilesC!
I'll assign you now and start the review issue

@xuanxu
Copy link
Member

xuanxu commented Mar 29, 2019

@whedon assign @aquilesC as reviewer

@whedon
Copy link
Author

whedon commented Mar 29, 2019

OK, the reviewer is @aquilesC

@xuanxu
Copy link
Member

xuanxu commented Mar 29, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Mar 29, 2019

OK, I've started the review over in #1352. Feel free to close this issue now!

@xuanxu
Copy link
Member

xuanxu commented Mar 29, 2019

@aquilesC, please head over to #1352 for the actual review

@xuanxu xuanxu closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants