Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions #182

Merged
merged 11 commits into from
May 4, 2021
Merged

Conversation

brettcannon
Copy link
Contributor

@brettcannon brettcannon commented Apr 30, 2021

Description (e.g. "Related to ...", etc.)

Introduce GitHub Actions for CI. This will run all tests and linting on each PR and push to the repository.

It will also build the example JSON extension as appropriate. This required introducing an ESLint configuration file which checks for errors and common mistakes.

Closes #172

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@brettcannon
Copy link
Contributor Author

Demo of the workflows running: https://github.com/brettcannon/pygls/actions.

@brettcannon
Copy link
Contributor Author

I also didn't remove the Azure Pipelines configuration as I wasn't sure if you wanted to keep both, remove it in this PR, remove it in a separate PR, etc.

@danixeee danixeee self-requested a review May 3, 2021 11:14
@danixeee danixeee added the devops Infrastructure, deployment, etc. label May 3, 2021
Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

I noticed that the json-extension vsix artifact is not uploaded after successful build. Could you check it?

No files were found with the provided path: *.vsix. No artifacts will be uploaded.

@brettcannon
Copy link
Contributor Author

I addressed the review comments and made it an error if no extension gets uploaded.

Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, I'll remove Azure Pipelines. Thanks!

@danixeee danixeee merged commit f9463d2 into openlawlibrary:master May 4, 2021
@brettcannon brettcannon deleted the github-actions branch May 5, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Infrastructure, deployment, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Azure Pipelines to GitHub Actions
5 participants