-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub actions #182
Add GitHub actions #182
Conversation
Added pyproject.toml
Demo of the workflows running: https://github.com/brettcannon/pygls/actions. |
I also didn't remove the Azure Pipelines configuration as I wasn't sure if you wanted to keep both, remove it in this PR, remove it in a separate PR, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
I noticed that the json-extension
vsix artifact is not uploaded after successful build. Could you check it?
No files were found with the provided path: *.vsix. No artifacts will be uploaded.
I addressed the review comments and made it an error if no extension gets uploaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, I'll remove Azure Pipelines. Thanks!
Description (e.g. "Related to ...", etc.)
Introduce GitHub Actions for CI. This will run all tests and linting on each PR and push to the repository.
It will also build the example JSON extension as appropriate. This required introducing an ESLint configuration file which checks for errors and common mistakes.
Closes #172
Code review checklist (for code reviewer to complete)
Docstrings have been included and/or updated, as appropriateStandalone docs have been updated accordinglyChangelog has been updated, as needed (see CHANGELOG.md)