Replace "transports" with "writers" #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #507 be merged first
Now that we use the high-level asyncio APIs, it no longer makes sense for
JsonRPCProtocol
to be a subclass ofasyncio.Protocol
. This PR convertsJsonRPCProtocol
into a simple class, cleaning up some dead code in the processIt also
renames the concept of "transport" to "writer" which aligns better with the reader/writer pair you often see in the high-level asyncio APIs.
renames the
connection_made
method toset_writer
, also incorporating aninclude_headers
flag.Before
After
Adds relevant typing protocols and writer classes to the
pygls.io_
moduleTweaks the handling of writers, so that both sync and async methods on the writer object can be used.
Code review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: