Ressurrect our pyodide support #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcarney
force-pushed
the
pyodide
branch
2 times, most recently
from
26ed8db to
425f36d
Compare
This should be all we need to add basic support for both pyodide and wasi WASM runtimes
This adds a new `pyodide` value for the option `--lsp-runtime` argument to the test suite. When given pytest will attempt to use a (pre-setup) pyodide environment to run the end-to-end tests in. This should resolve all the issues we had with the old pyodide test suite as we are not trying to shove pytest, pytest-asyncio etc and all of their complexity into pyodide.
This should resolve all the deprecation warnings
This commit attempts to add a bit more structure to the documentation, hopefully making it easier to navigate as the number of articles slowly grows
|
Thanks! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #508 to be merged first
The existing "support" for pyodide hasn't received much attention since it was originally merged (sorry! 😅). This PR should finally fix that!
pyglsdetects that it is running in a WASM environment, thestart_iomethod will by default, now fallback to a synchronous main loop which is actually all we need to get it to work--lsp-runtime pyodideand pytest will try and run just the end-to-end tests in pyodide. (Seetests/pyodide/run_server.jsfor the details of getting the server up and running)TODO
Code review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: