Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle source data file not found #43

Closed
joemull opened this issue Jan 3, 2024 · 0 comments · Fixed by #49
Closed

Handle source data file not found #43

joemull opened this issue Jan 3, 2024 · 0 comments · Fixed by #49
Assignees
@joemull
Labels
bug

Comments

@joemull
Copy link
Member

joemull commented Jan 3, 2024

Filename based on current year causes open function to fail when only data from a previous year exists. This should handle a file not found:

https://github.com/BirkbeckCTP/consortial_billing/blob/9c4f9fd0362f741805a2117a3776fc1f78cf1433/utils.py#L103-L105
@joemull joemull added the bug label Jan 3, 2024
@joemull joemull self-assigned this Jan 3, 2024
@joemull joemull added this to v1.5.2 Jan 3, 2024
@joemull joemull moved this to Todo in v1.5.2 Jan 3, 2024
@joemull joemull assigned joemull and unassigned joemull Feb 15, 2024
joemull added a commit that referenced this issue Feb 19, 2024
@joemull
Handle missing media file gracefully #43
faff5c3
@joemull joemull mentioned this issue Feb 19, 2024
Merged
@joemull joemull moved this from Todo to PR Submitted in v1.5.2 Feb 21, 2024
joemull added a commit that referenced this issue Feb 22, 2024
@joemull
Rename function to make JSON return clearer #43
c632ddf
mauromsl pushed a commit that referenced this issue Feb 27, 2024
@joemull @mauromsl
Handle missing media file gracefully #43
3301b69
mauromsl pushed a commit that referenced this issue Feb 27, 2024
@joemull @mauromsl
Rename function to make JSON return clearer #43
f86efc0
@github-project-automation github-project-automation bot moved this from PR Submitted to Done in v1.5.2 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joemull joemull

Labels
bug
Projects
No open projects
v1.5.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pages still load even if a JSON data file is missing openlibhums/consortial_billing
1 participant
@joemull