Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages still load even if a JSON data file is missing #49

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Pages still load even if a JSON data file is missing #49

merged 2 commits into from
Feb 27, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Feb 19, 2024

Fixes #43

@joemull joemull requested review from ajrbyers and mauromsl February 19, 2024 14:16
mauromsl
mauromsl requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick but otherwise good

@joemull
Copy link
Member Author

joemull commented Feb 22, 2024 •
edited
Loading

Minor nitpick but otherwise good

Thanks @mauromsl but I don't see any comments under this--did they not get saved?

@joemull joemull requested a review from mauromsl February 22, 2024 08:09
mauromsl
mauromsl requested changes Feb 22, 2024
View reviewed changes
utils.py Outdated Show resolved Hide resolved
@mauromsl
Copy link
Member

Minor nitpick but otherwise good

Thanks @mauromsl but I don't see any comments under this--did they not get saved?

yeah odd, it picked the overall comment but not the inline. It is there now

@joemull joemull requested a review from mauromsl February 22, 2024 11:34
@mauromsl mauromsl merged commit f86efc0 into master Feb 27, 2024
@joemull joemull mentioned this pull request Mar 14, 2024
Closed
@joemull joemull deleted the 43-fix-missing-media-file branch September 20, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

@ajrbyers ajrbyers ajrbyers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle source data file not found
3 participants
@joemull @mauromsl @ajrbyers