reproducibility: sort surf source bank before write #2500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closing because this has passed CI and Chris has rebased this into the time cutoff PR. |
Contributor
|
thanks again |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at the code where we load particles into the surface source bank (
Particle::cross_surface), you'll see that we probably should be sorting this bank before writing in order to ensure the same output file is produced each time without regard to the order threads run in. It appears that this race condition caused unlucky CI failure for @cfichtlscherer, so if he can rebase on this and pass CI, we should definitely merge this tiny change.