Skip to content

reproducibility: sort surf source bank before write #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gridley wants to merge 1 commit into from
Closed

reproducibility: sort surf source bank before write #2500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/simulation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,18 @@ void finalize_batch()
auto filename = settings::path_output + "surface_source";
auto surf_work_index =
mpi::calculate_parallel_index_vector(simulation::surf_source_bank.size());

// Sort, because the file ordering will differ based on the order that
// threads finish work in. We want to produce the same output every time
// given the same random seed. We probably don't need to sort globally over
// MPI ranks to ensure reproducible output.
std::sort(simulation::surf_source_bank.begin(),
simulation::surf_source_bank.end(),
[](const SourceSite& l, const SourceSite& r) {
return std::tie(l.parent_id, l.progeny_id) <
std::tie(r.parent_id, r.progeny_id);
});

gsl::span<SourceSite> surfbankspan(simulation::surf_source_bank.begin(),
simulation::surf_source_bank.size());
if (settings::surf_mcpl_write) {
Expand Down