-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laid out infrastructure for switching to black formatting all code. #3222
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 95804f6. THis was the wrong file for this.
Failure of Python-format-test is to be expected, and shows that the test is working. |
Awesome, particularly keen on this PR as I think it will save a lot of human time reviewing and suggesting minor formatting changes on PRs. Could also consider changing this line in the PR template openmc/.github/pull_request_template.md Line 16 in de8132a
|
Are you thinking of adding "I have ran black" language to this? |
Yep perhaps good to keep it as a single check box. Something like I have run Clang on C++ code changes and Black on Python code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on adding the badge to the README.md? It's purely cosmetic but could be fun and a way for users to find the project.
Looks like python 3.10.0
did go out of SPEC 0 in October, but some of the other minor versions were released after. For example, I'm still using 3.10.5 locally, and that was released in June 2022. What is the policy on SPEC 0 for minor versions?
|
Is it worth considering using pre commit for black formatting |
I personally prefer to run black manually. I feel like this is more of a personal developer choice. |
Description
The goal of this PR is to actually be PEP8, and enforce it. This does so by:
black --check
To avoid confusion this PR does not actually apply black, that is done in #3223.
Fixes #2002
Checklist