-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually Black format everything #3223
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 95804f6. THis was the wrong file for this.
Wondering if this PR got lost over the holidays and new year. Is anyone opposed to this or does any of the leadership team have a strong opinion one way or the other? I do support black formatting, as I'm finding when I try to edit source code for a different PR, my black formatter is formatting previously merged code. Apparently black has a unique formatting choice (that can be tweaked with certain settings e.g. max line length), which is desirable to me to more easily prevent unwanted diffs in my PRs. I can live with changing my formatter settings for openmc and manually formatting source code additions, but I think it would be cool to unify the formatting. We can always use the |
Description
This is a follow-on to #3222 that actually formats everything with black.
Proposed way to merge.
black
locally ondevelop
and then compare with this PR. I think this is the only way to verify nothing was snuck in with so many changes.black
against their branch and commit.develop
. This should eliminate almost all merge conflicts.Fixes #2002 (actually implement.)
Checklist